Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 BUG]: Services manager wrong processNum from php client #1621

Closed
1 task done
asanikovich opened this issue Jun 26, 2023 · 9 comments · Fixed by roadrunner-server/service#44
Closed
1 task done
Assignees
Labels
B-bug Bug: bug, exception B-regression Bug: regression bugs
Milestone

Comments

@asanikovich
Copy link

asanikovich commented Jun 26, 2023

No duplicates 🥲.

  • I have searched for a similar issue in our bug tracker and didn't find any solutions.

What happened?

I tries by RoadRunner Service Plugin docs https://roadrunner.dev/docs/plugins-service/current/en to run process in 3 copies from php client (code below).
But it creates only 1 process.
In the RPC I can see that 3 are passing.

Version (rr --version)

rr version 2023.1.5 (build time: 2023-06-08T14:45:04+0000, go1.20.5), OS: linux, arch: amd64
Php libraries:
"spiral/roadrunner-cli": "2.5.0",
"spiral/roadrunner-http": "3.0.1",
"spiral/roadrunner-kv": "4.0.0",
"spiral/roadrunner-metrics": "3.0.0",
"spiral/roadrunner-services": "2.0.0",

How to reproduce the issue?

        $result = $this->manager->create(
            name: $commandBase,
            command: sprintf('php artisan %s', $command),
            processNum: 3,
            remainAfterExit: (bool)$autoRestart,
            restartSec: 1
        );

Relevant log output

No response

@asanikovich asanikovich added B-bug Bug: bug, exception F-need-verification labels Jun 26, 2023
@asanikovich asanikovich changed the title [🐛 BUG]: Services manager processNum always 1 [🐛 BUG]: Services manager wrong processNum from php client Jun 26, 2023
@rustatian
Copy link
Member

Hey @asanikovich 👋🏻
How you determine, that only 1 process fired?

@asanikovich
Copy link
Author

I see in process manager (top) that only 1 run process running.

@rustatian
Copy link
Member

Ok, got u, let me verify that

@rustatian
Copy link
Member

You're right @asanikovich 👍🏻 Bug confirmed. Will be fixed and released in the 2023.2.0 release.

@rustatian rustatian added B-regression Bug: regression bugs and removed F-need-verification labels Jun 27, 2023
@rustatian rustatian added this to the v2023.2.0 milestone Jun 27, 2023
@github-project-automation github-project-automation bot moved this to Backlog in General Jun 27, 2023
@rustatian rustatian moved this from Backlog to In Progress in General Jun 27, 2023
@rustatian
Copy link
Member

As a temporary workaround, you can use .rr.yaml configuration to define the required number of processes. Seems to be an RPC service creation bug only.

@asanikovich
Copy link
Author

I need to dynamically run processes from RPC

@rustatian
Copy link
Member

Got u, then please wait for 2023.2.0, scheduled to release in early July.

@asanikovich
Copy link
Author

Why there is no "service_name_in_log" parameter to run service process from rpc?

@rustatian
Copy link
Member

Feel free to create a feature request to add that option in the RPC transport as well 😃

@github-project-automation github-project-automation bot moved this from In Progress to Unreleased in General Jun 27, 2023
@rustatian rustatian moved this from Unreleased to Done in General Jul 6, 2023
@rustatian rustatian mentioned this issue Jul 6, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-bug Bug: bug, exception B-regression Bug: regression bugs
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants