Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 BUG?]: Delete tmp files after the multipart form is parsed #1002

Closed
1 task done
rustatian opened this issue Feb 10, 2022 · 2 comments · Fixed by roadrunner-server/http#29
Closed
1 task done
Assignees
Labels
B-bug Bug: bug, exception F-need-verification Y-high Priority: High
Milestone

Comments

@rustatian
Copy link
Member

rustatian commented Feb 10, 2022

No duplicates 🥲.

What happened?

Check the temp files after the multipart form is parsed. There is no Remove method called on the multipart form in the http plugin.

Version

all

Relevant log output

/var/www/html # rr serve
1.644458566951385e+09   debug   rpc     plugin was started      {"address": "tcp://127.0.0.1:6001", "list of the plugins with RPC methods:": ["informer", "resetter"]}
[INFO] RoadRunner server started; version: 2.7.4, buildtime: 2022-01-21T23:03:24+0000
1.6444585683093784e+09  debug   server  worker is allocated     {"pid": 1535, "internal_event_name": "EventWorkerConstruct"}
1.6444585683313837e+09  debug   server  worker is allocated     {"pid": 1539, "internal_event_name": "EventWorkerConstruct"}
1.6444585683333237e+09  debug   http    http server was started {"address": "0.0.0.0:8080"}
1.6444585711260376e+09  info    http    http log        {"status": 200, "method": "GET", "URI": "http://localhost:3030/status", "remote_address": "172.24.0.1", "start": 1644458571.0842135, "elapsed": 0.0418046}
1.6444585870782511e+09  info    server  {"level":"INFO","timestamp":"2022-02-10T02:03:07.077547+00:00","env":"local","message":"/tmp/symfony6204725abb0251.73456105KMLEJK","context":[],"extra":[]}
1.6444585870806518e+09  info    server  {"level":"INFO","timestamp":"2022-02-10T02:03:07.079992+00:00","env":"local","message":"58696459","context":[],"extra":[]}
1.6444585870947886e+09  info    http    http log        {"status": 200, "method": "POST", "URI": "http://localhost:3030/upload", "remote_address": "172.24.0.1", "start": 1644458585.54683, "elapsed": 1.5479301}
1.6444586088064666e+09  error   http    error opening the file  {"error": "open /tmp/multipart-2768224916: no such file or directory"}
1.6444586088189597e+09  info    http    http log        {"status": 200, "method": "GET", "URI": "http://localhost:3030/status", "remote_address": "172.24.0.1", "start": 1644458608.8062859, "elapsed": 0.0126417}
1.6444586094928615e+09  error   http    error opening the file  {"error": "open /tmp/multipart-2768224916: no such file or directory"}
1.6444586095079334e+09  info    http    http log        {"status": 200, "method": "GET", "URI": "http://localhost:3030/status", "remote_address": "172.24.0.1", "start": 1644458609.4927492, "elapsed": 0.0151564}
@rustatian rustatian added B-bug Bug: bug, exception F-need-verification labels Feb 10, 2022
@rustatian rustatian self-assigned this Feb 10, 2022
@rustatian rustatian moved this to Todo in General Feb 10, 2022
@rustatian rustatian added the Y-high Priority: High label Feb 10, 2022
@rustatian rustatian changed the title [🐛 BUG?]: Delete tmp files after multipart form is parsed [🐛 BUG?]: Delete tmp files after the multipart form is parsed Feb 10, 2022
@rustatian rustatian modified the milestones: v2.7.8, v2.7.9 Feb 12, 2022
@rustatian
Copy link
Member Author

Sorry for the delay. This issue might happen when some error occurs, and we won't properly close the MultipartForm.

@rustatian rustatian added this to the v2.10.1 milestone May 17, 2022
Repository owner moved this from Todo to Unreleased in General May 17, 2022
@rustatian
Copy link
Member Author

image
tmp
image
deleted
image

@rustatian rustatian moved this from Unreleased to Done in General May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-bug Bug: bug, exception F-need-verification Y-high Priority: High
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant