From 7b69ed7547e7e5c70d15184bc73bc7edcfca738b Mon Sep 17 00:00:00 2001
From: Valery Piashchynski <piashchynski.valery@gmail.com>
Date: Thu, 5 Sep 2024 16:13:15 +0200
Subject: [PATCH] chore: properly check interface type for nil

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
---
 .golangci.yml |  2 +-
 plugin.go     | 10 +++++++++-
 rpc.go        |  1 -
 3 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/.golangci.yml b/.golangci.yml
index 98bb8b9..7c583b7 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -41,7 +41,7 @@ linters: # All available linters list: <https://golangci-lint.run/usage/linters/
     - errcheck # Errcheck is a program for checking for unchecked errors in go programs. These unchecked errors can be critical bugs in some cases
     - errorlint # find code that will cause problems with the error wrapping scheme introduced in Go 1.13
     - exhaustive # check exhaustiveness of enum switch statements
-    - exportloopref # checks for pointers to enclosing loop variables
+    - copyloopvar # checks for pointers to enclosing loop variables
     - gochecknoglobals # Checks that no globals are present in Go code
     - gochecknoinits # Checks that no init functions are present in Go code
     - goconst # Finds repeated strings that could be replaced by a constant
diff --git a/plugin.go b/plugin.go
index c3e34e1..74afd5d 100644
--- a/plugin.go
+++ b/plugin.go
@@ -9,6 +9,7 @@ import (
 	"time"
 
 	jobsApi "github.com/roadrunner-server/api/v4/plugins/v4/jobs"
+	"github.com/roadrunner-server/pool/pool/static_pool"
 	jprop "go.opentelemetry.io/contrib/propagators/jaeger"
 	"go.opentelemetry.io/otel"
 	"go.opentelemetry.io/otel/propagation"
@@ -224,7 +225,14 @@ func (p *Plugin) Stop(ctx context.Context) error {
 		// workers' pool should be stopped
 		p.mu.Lock()
 		if p.workersPool != nil {
-			p.workersPool.Destroy(ctx)
+			switch pp := p.workersPool.(type) {
+			case *static_pool.Pool:
+				if pp != nil {
+					pp.Destroy(ctx)
+				}
+			default:
+				// pool is nil, nothing to do
+			}
 		}
 		p.mu.Unlock()
 	}()
diff --git a/rpc.go b/rpc.go
index 40c9992..e7ee667 100644
--- a/rpc.go
+++ b/rpc.go
@@ -146,7 +146,6 @@ func (r *rpc) Destroy(req *jobsProto.Pipelines, resp *jobsProto.Pipelines) error
 
 	var destroyed []string
 	for i := 0; i < len(req.GetPipelines()); i++ {
-		i := i
 		errg.Go(func() error {
 			ctx, span := r.p.tracer.Tracer(spanName).Start(context.Background(), "destroy_pipeline", trace.WithSpanKind(trace.SpanKindServer))
 			err := r.p.Destroy(ctx, req.GetPipelines()[i])