Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create v0.17.1 release with rnp_signature_get_features #2189

Closed
ronaldtse opened this issue Feb 9, 2024 · 10 comments
Closed

Create v0.17.1 release with rnp_signature_get_features #2189

ronaldtse opened this issue Feb 9, 2024 · 10 comments
Assignees
Milestone

Comments

@ronaldtse
Copy link
Contributor

Description

Source: 74b70af#commitcomment-138429079

From @kaie :

Would the RNP team be willing to create a v0.17.1 release, based on the former v0.17.0 release, which adds this feature (commit)? This could allow those Linux distributions which ship RNP separately, to pick up this feature easily, and allow Thunderbird to make use of the new API in its current stable 115.x release.

@ni4
Copy link
Contributor

ni4 commented Feb 9, 2024

@ronaldtse I think adding #2180 contents to release would be good idea?

@ni4 ni4 mentioned this issue Feb 11, 2024
@ronaldtse
Copy link
Contributor Author

Agree with @ni4 . Thanks!

@ni4
Copy link
Contributor

ni4 commented Feb 27, 2024

...also required to pick CI updates + Botan 3 support + OpenSSL 3.0 fixes (see #2190). @kaie don't you mind these changes? They should not have an impact for already existing behaviour and improve compatibility.

@kaie
Copy link
Contributor

kaie commented Feb 28, 2024

Hi @ni4 - If your intention is to include correctness fixes, plus compatibility fixes for a wider set of build environments and libraries, that makes sense to me. I'd suggest that you ask yourself: Would any long term support environment, that currently ships Thunderbird 115.x, and is willing to take updates for it, but that also wants to minimize the amount of fixes it takes, be fine with your included changes? For example, stable Debian or RHEL? I'd exclude changes those stable environments might be unwilling to bring in.

@kaie
Copy link
Contributor

kaie commented Feb 28, 2024

CC @jfx2006

@ni4
Copy link
Contributor

ni4 commented Mar 2, 2024

@kaie Yeah, this is mostly for systems which updated to Botan 3/latest OpenSSL 3.0 (like #2159). For LTE nothing would change as they would continue to use older Botan/OpenSSL packages.

@ni4 ni4 added this to the v0.17.1 milestone Mar 11, 2024
@kaie
Copy link
Contributor

kaie commented Apr 17, 2024

Hello, do you expect this to happen very soon, or are you blocked?

@ni4
Copy link
Contributor

ni4 commented Apr 17, 2024

@kaie The only blocker was this thing : #2209 , however now it seems to be not of that importance as it is easily solvable by maintainers and mostly related to the v0.17.0.

@ni4
Copy link
Contributor

ni4 commented May 14, 2024

Finally release is published: https://github.com/rnpgp/rnp/releases/tag/v0.17.1

@ni4 ni4 closed this as completed May 14, 2024
@kaie
Copy link
Contributor

kaie commented May 14, 2024

Thank you. FYI, the release page also says function set_features was added, I assume that's a mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants