Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENABLE_IDEA not working #1901

Closed
jfx2006 opened this issue Sep 11, 2022 · 1 comment · Fixed by #1903
Closed

ENABLE_IDEA not working #1901

jfx2006 opened this issue Sep 11, 2022 · 1 comment · Fixed by #1903
Assignees
@ni4
Milestone
v0.16.2

Comments

@jfx2006
Copy link
Contributor

jfx2006 commented Sep 11, 2022

Description

In 0.16.1, IDEA support does not get enabled despite Botan supporting it

Steps to Reproduce

  1. Run cmake -S rnp-0.16.1 -B build
  2. Build: cd build && make
  3. Execute the built "rnpkeys" binary without any arguments: ./src/rnpkeys/rnpkeys

Expected Behavior

The "Encryption" line should include "IDEA" in its list

Actual Behavior

IDEA does not appear in the "Encryption" line:
Encryption: TRIPLEDES, CAST5, BLOWFISH, AES128, AES192, AES256, TWOFISH, CAMELLIA128, CAMELLIA192, CAMELLIA256, SM4

Adding #cmakedefine ENABLE_IDEA to be src/lib/config.h.in fixes the issue.
@ni4
Copy link
Contributor

ni4 commented Sep 12, 2022

@jfx2006 Wow, how could we (and our tests) miss that! Thanks for reporting, we'll work on fixing this.

@ni4 ni4 self-assigned this Sep 12, 2022
@ni4 ni4 added this to the v0.16.2 milestone Sep 12, 2022
@ni4 ni4 mentioned this issue Sep 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ni4 ni4

Labels
None yet
Projects
None yet
Milestone
v0.16.2
Development

Successfully merging a pull request may close this issue.

Make sure that RNP supports all features which should be supported. ni4/rnp
2 participants
@jfx2006 @ni4