fix(sqlparser): allow single quoted value for set time zone
#9962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangjinwu
commented
May 23, 2023
Comment on lines
-3588
to
-3591
| } else if let Ok(ident) = self.parse_identifier() { | ||
| SetTimeZoneValue::Ident(ident) | ||
| } else { | ||
| let value = self.parse_value()?; |
There was a problem hiding this comment.
parse_value() after a failed parse_identifier() does not work because the token position is not restored with prev_token(). But instead of using prev_token(), we follow the same pattern as parse_set_variable: use one peek_xxx and one parse_xxx
Codecov Report
@@ Coverage Diff @@
## main #9962 +/- ##
=======================================
Coverage 71.16% 71.16%
=======================================
Files 1249 1249
Lines 209513 209514 +1
=======================================
+ Hits 149100 149105 +5
+ Misses 60413 60409 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
TennyZhuang
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Allow
set time zone 'utc';(in addition toset time zone utc;without quotes).see #8572 (comment)
used by cube #9946
Checklist For Contributors
./risedev check(or alias,./risedev c)Documentation