Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add nexmark with watermark planner test #9711

Merged
merged 3 commits into from
May 15, 2023
Merged

Conversation

lmatz
Copy link
Contributor

@lmatz lmatz commented May 9, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

@lmatz
Copy link
Contributor Author

lmatz commented May 9, 2023

I tried but found it impossible for me to change the Flink's Nexamrk q7 to use standard hash inner join (by query hints) instead of interval join: #7244 (comment)
So I intend to enable watermark in RW's Nexmark tests to use the interval join.

@github-actions github-actions bot added component/test Test related issue. user-facing-changes Contains changes that are visible to users labels May 9, 2023
@lmatz lmatz removed the user-facing-changes Contains changes that are visible to users label May 9, 2023
@lmatz lmatz requested review from chenzl25 and st1page May 10, 2023 02:09
Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must create the VIEW with the generated datatime column with watermark instead of the original datatime.

@lmatz lmatz force-pushed the lz/nexmark_watermark branch from 9edff4a to 918c051 Compare May 11, 2023 05:37
@lmatz
Copy link
Contributor Author

lmatz commented May 11, 2023

Thanks, I updated

@@ -0,0 +1,2157 @@
# This file is automatically generated. See `src/frontend/planner_test/README.md` for more information.
- id: create_sources
sql: "CREATE SOURCE nexmark (\n event_type BIGINT,\n person STRUCT<\"id\" BIGINT,\n \"name\" VARCHAR,\n \"email_address\" VARCHAR,\n \"credit_card\" VARCHAR,\n \"city\" VARCHAR,\n \"state\" VARCHAR,\n \"date_time\" TIMESTAMP,\n \"extra\" VARCHAR>,\n auction STRUCT<\"id\" BIGINT,\n \"item_name\" VARCHAR,\n \"description\" VARCHAR,\n \"initial_bid\" BIGINT,\n \"reserve\" BIGINT,\n \"date_time\" TIMESTAMP,\n \"expires\" TIMESTAMP,\n \"seller\" BIGINT,\n \"category\" BIGINT,\n \"extra\" VARCHAR>,\n bid STRUCT<\"auction\" BIGINT,\n \"bidder\" BIGINT,\n \"price\" BIGINT,\n \"channel\" VARCHAR,\n \"url\" VARCHAR,\n \"date_time\" TIMESTAMP,\n \"extra\" VARCHAR>,\n date_time TIMESTAMP AS\n CASE\n WHEN event_type = 0 THEN (person).date_time\n WHEN event_type = 1 THEN (auction).date_time\n ELSE (bid).date_time\n END,\n WATERMARK FOR date_time AS date_time - INTERVAL '4' SECOND\n) WITH (\n connector = 'nexmark',\n nexmark.split.num = '2',\n nexmark.min.event.gap.in.ns = '100'\n);\n\nCREATE VIEW PERSON as \nselect \n (person).id, (person).name, (person).email_address, (person).credit_card, (person).city, (person).state, \n date_time, (person).extra\nfrom \n nexmark \nwhere event_type = 0;\n\nCREATE VIEW AUCTION as \nselect \n (auction).id, (auction).item_name, (auction).description, (auction).initial_bid, (auction).reserve, date_time,\n (auction).expires, (auction).seller, (auction).category, (auction).extra\nfrom \n nexmark \nwhere event_type = 1;\n\nCREATE VIEW BID as \nselect \n (bid).auction, (bid).bidder, (bid).price, (bid).channel, (bid).url, date_time, (bid).extra\nfrom \n nexmark \nwhere event_type = 2;\n"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

....
I wrote in the normal way
and the generator compressed them into a single-line string...

@lmatz
Copy link
Contributor Author

lmatz commented May 12, 2023

If it's good, then I will start to use them in the daily performance test

@st1page
Copy link
Contributor

st1page commented May 15, 2023

Btw, can you help to add eowc_stream_plan: | for each test? thanks.

@BugenZhao
Copy link
Member

BugenZhao commented May 15, 2023

Might be related: #9588. There're too many possible combinations! 😄

  • source vs table
  • all-in-one vs 3 sources
  • mview vs sink
  • watermark or not
  • proctime or not
  • EoWC or not

@lmatz
Copy link
Contributor Author

lmatz commented May 15, 2023

Btw, can you help to add eowc_stream_plan: | for each test? thanks.

sure, updated it

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #9711 (c881be6) into main (adb8e08) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #9711      +/-   ##
==========================================
+ Coverage   70.98%   71.00%   +0.01%     
==========================================
  Files        1246     1246              
  Lines      208377   208377              
==========================================
+ Hits       147918   147950      +32     
+ Misses      60459    60427      -32     
Flag Coverage Δ
rust 71.00% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lmatz lmatz added this pull request to the merge queue May 15, 2023
Merged via the queue into main with commit 05e7de4 May 15, 2023
@lmatz lmatz deleted the lz/nexmark_watermark branch May 15, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Test related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants