feat(storage): compactor skip sst and block related to non-existent able_id #9707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nexmark test with q1 After I manually drop q1 mv, the compactor will skip the non-existent (table) sst when build_sst_iter
|
hzxa21
reviewed
May 9, 2023
Comment on lines
130
to
135
| while self.remaining_blocks > 0 && let Some(block) = self.download_next_block().await? { | ||
| self.remaining_blocks -= 1; | ||
| let block_table_id = block.table_id(); | ||
| if !self.existing_table_ids.contains(&block_table_id.table_id) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
This optimization is already done in #8489. See prune_from_valid_block_iter for details.
There was a problem hiding this comment.
No...It seems we did not remove table-id from SstableInfo when unregister state tables
Codecov Report
@@ Coverage Diff @@
## main #9707 +/- ##
=======================================
Coverage 70.97% 70.97%
=======================================
Files 1241 1241
Lines 207703 207713 +10
=======================================
+ Hits 147412 147430 +18
+ Misses 60291 60283 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As we continue to create and delete tables, the residual data from the tables will still take up compactor resources. This pr skips non-existent data from the table and block perspective to reduce resource usage.
part of #9706
Checklist For Contributors
./risedev check(or alias,./risedev c)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note