-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(executor, frontend): StreamHopWindow
executor should derive window expr in frontend
#8415
Conversation
…into jon/batch-hop-window-derive-exprs-in-frontend
…://github.com/singularity-data/risingwave into jon/batch-hop-window-derive-exprs-in-frontend
BatchHopWindow
executor should derive window expr in frontendStreamHopWindow
executor should derive window expr in frontend
…into jon/stream-hop-window-frontend-derive
Codecov Report
@@ Coverage Diff @@
## main #8415 +/- ##
==========================================
- Coverage 71.64% 71.64% -0.01%
==========================================
Files 1135 1135
Lines 185600 185621 +21
==========================================
+ Hits 132978 132991 +13
- Misses 52622 52630 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I think this may break existing pipeline. |
Hmm, why is that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think it is because we persist in the streaming plan proto in the meta store and our new implementation can not handle the old plan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It is a breaking change and seems to be unable to provide backward compatibility.
…dow expr in frontend (#8415) Co-authored-by: jon-chuang <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Stream Hop executor should derive expr in frontend. e2e test previously panicked with variable duration interval due to not inlining session timezone.
Notes:
BatchHopWindow
executor should derive window expr in frontend #8403 to be mergedChecklist For Contributors
./risedev check
(or alias,./risedev c
)Documentation
Related
Fixes part of: #7334