-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(executor, frontend): BatchHopWindow
executor should derive window expr in frontend
#8403
fix(executor, frontend): BatchHopWindow
executor should derive window expr in frontend
#8403
Conversation
…into jon/batch-hop-window-derive-exprs-in-frontend
…://github.com/singularity-data/risingwave into jon/batch-hop-window-derive-exprs-in-frontend
Codecov Report
@@ Coverage Diff @@
## main #8403 +/- ##
==========================================
- Coverage 71.62% 71.62% -0.01%
==========================================
Files 1135 1135
Lines 185248 185458 +210
==========================================
+ Hits 132689 132837 +148
- Misses 52559 52621 +62
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally LGTM.
A potential problem is that it might produce a large plan node. It might be critical in serving situations(with high QPS). But I think the window TVF is hardly used in that situation. So it is not necessary to do that optimization prematurely.
Yes, it does not seem too likely to use a hop window in serving scenario. |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Batch Hop executor should derive expr in frontend. e2e test previously panicked with variable duration interval due to not inlining session timezone.
Next step: stream
Checklist For Contributors
./risedev check
(or alias,./risedev c
)Documentation
Related
Fixes part of: #7334