-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(common): introduce SerialArrayBuilder and SerialArray #8357
Conversation
…er` from new location; cleanup code.
15ea0aa
to
f37ef4c
Compare
Codecov Report
@@ Coverage Diff @@
## main #8357 +/- ##
==========================================
- Coverage 71.56% 71.56% -0.01%
==========================================
Files 1132 1132
Lines 184249 184262 +13
==========================================
+ Hits 131853 131858 +5
- Misses 52396 52404 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/common/src/array/serial_array.rs
Outdated
#[derive(Debug)] | ||
pub struct SerialArrayBuilder(PrimitiveArrayBuilder<i64>); | ||
|
||
#[derive(Debug, Clone)] | ||
pub struct SerialArray(PrimitiveArray<i64>); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about impl PrimitiveArrayItemType for Serial
and then pub type SerialArray = PrimitiveArray<Serial>;
(see NaiveDateArray
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, i'll try it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Changes Made
HashKeySerDe
forSerial
Serial
to various functions and modules in the codebaseSerialArrayBuilder
andSerialArray
types for building and representing arrays ofSerial
Purpose
The purpose of these changes is to add support for a new
SERIAL
type and enable its usage in various functions and modules in the codebase. This is done by definingSerialArrayBuilder
andSerialArray
types for building and representing arrays ofSerial
. The changes also include updating tests to reflect these new additions.Checklist For Contributors
- [ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934)../risedev check
(or alias,./risedev c
)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note