Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): introduce Serial as Scalar and ScalarRef #8327

Merged
merged 2 commits into from
Mar 3, 2023

Conversation

shanicky
Copy link
Contributor

@shanicky shanicky commented Mar 3, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This pull request adds a new module, serial_array, to the src/common/src/array/ directory, which contains an implementation for the Serial type. Serial has been included in the list of Scalar variants in src/common/src/types/mod.rs, with corresponding implementations for Scalar and ScalarRef. The ScalarRefImpl's implementation of ToBinary now includes Serial in the match statement. Additionally, serialize_scalar() in src/common/src/util/value_encoding/mod.rs has been modified to handle Serial.

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
    - [ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@@ -30,6 +30,7 @@ mod jsonb_array;
pub mod list_array;
mod macros;
mod primitive_array;
pub(crate) mod serial_array;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: mod serial_array and pub use those needed.

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #8327 (b5e8859) into main (870cbf7) will decrease coverage by 0.03%.
The diff coverage is 2.43%.

@@            Coverage Diff             @@
##             main    #8327      +/-   ##
==========================================
- Coverage   71.57%   71.54%   -0.03%     
==========================================
  Files        1130     1131       +1     
  Lines      184113   184154      +41     
==========================================
- Hits       131775   131759      -16     
- Misses      52338    52395      +57     
Flag Coverage Δ
rust 71.54% <2.43%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/array/mod.rs 73.06% <ø> (ø)
src/common/src/array/serial_array.rs 0.00% <0.00%> (ø)
src/common/src/types/to_binary.rs 37.50% <0.00%> (-0.80%) ⬇️
src/common/src/util/value_encoding/mod.rs 96.49% <0.00%> (-0.57%) ⬇️
src/common/src/types/mod.rs 73.16% <50.00%> (-0.16%) ⬇️
src/batch/src/executor/group_top_n.rs 68.23% <0.00%> (-6.48%) ⬇️
src/source/src/row_id.rs 90.90% <0.00%> (-1.14%) ⬇️
src/meta/src/hummock/mock_hummock_meta_client.rs 64.94% <0.00%> (-0.52%) ⬇️
...frontend/src/scheduler/hummock_snapshot_manager.rs 60.00% <0.00%> (-0.48%) ⬇️
src/common/src/types/ordered_float.rs 30.87% <0.00%> (-0.20%) ⬇️
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shanicky shanicky enabled auto-merge March 3, 2023 08:53
@shanicky shanicky added this pull request to the merge queue Mar 3, 2023
Merged via the queue into main with commit cce2ace Mar 3, 2023
@shanicky shanicky deleted the peng/serial-0-scalar branch March 3, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants