-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(source): intro native row format #7612
Conversation
e6bf3cc
to
36134f0
Compare
36134f0
to
317a428
Compare
since datagen connector and nexmark connector both produce stream chunks directly, I prefer rejecting row format in this case. It is hard to tell users what is native row format. |
PTAL #6970, it requires |
317a428
to
1c45f7d
Compare
Codecov Report
@@ Coverage Diff @@
## main #7612 +/- ##
==========================================
- Coverage 71.67% 71.58% -0.10%
==========================================
Files 1111 1111
Lines 176936 177229 +293
==========================================
+ Hits 126812 126862 +50
- Misses 50124 50367 +243
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hmmmm. I think #6970 is meant to generate data with a nested column i.e. STRUCT, ARRAY, JSON. While the |
It seems the main purpose of #6970 is to test source parsing, both nested column and more For performance, So I think we need to introduce a |
#6970 is meant to test source parsing of rows, I think @waruto210 has the right idea.
Instead of (this is done separately, see #7132):
|
1c45f7d
to
bf33c8d
Compare
a4c62ff
to
2b32204
Compare
4bea865
to
bc226e6
Compare
bc226e6
to
4ca4d8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basically LGTM
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
NATIVE
ROW FORMAT, which is the default row format ofnexmark
anddatagen
connecotr, and it is invisible to user.nexmark
only supportNATIVE
ROW FORMAT, butdatagen
can support multiple formats(onlynative
andjson
now)Checklist
- [ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features)../risedev check
(or alias,./risedev c
)Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.
Release note
nexmark: user should not specify row format
datagen: If user do not specify a row format, datagen would use
NATIVE
.Refer to a related PR or issue link (optional)
#6969 ,#4555