-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(connector): generate native Row when datagen to avoid json deser #6969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmatz
commented
Dec 20, 2022
lmatz
commented
Dec 20, 2022
0d57198
to
283a087
Compare
lmatz
commented
Dec 22, 2022
04e40e0
to
4487e1e
Compare
Codecov Report
@@ Coverage Diff @@
## main #6969 +/- ##
=========================================
+ Coverage 0 72.88% +72.88%
=========================================
Files 0 1041 +1041
Lines 0 167213 +167213
=========================================
+ Hits 0 121872 +121872
- Misses 0 45341 +45341
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
6 tasks
#7032 will make this unnecessary, close now. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
#4555 #4961
Use
Box::into_raw
to leak the memory, and thenBox::from_raw
to reclaim the ownership of that piece of memory.introduce keywords NATIVE
and create a special
native
parser for that.I guess creating individual rows and then sending them row by row is still suboptimal, compared to creating columns (column by column, so create, e.g. 1024, the same types of data each time) to compose a
StreamChunk
.This is unsafe but limited to a small scope.
No reason to free the memory twice as it requires using the
Bytes
twice, which itself would suggest it's a suboptimal implementation.Comparison on c5.4xLarge EC2.
Query:
risedev.yml:
This pr:

commit: 94d508a:

So more than 2X improvement.
Guess the improvement can be artificially increased by specifying more and longer column names, and more and larger column values.
Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)