refactor: remove keyspace #6406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6406 +/- ##
==========================================
- Coverage 74.28% 74.12% -0.17%
==========================================
Files 960 966 +6
Lines 156525 158029 +1504
==========================================
+ Hits 116277 117141 +864
- Misses 40248 40888 +640
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Li0k
reviewed
Nov 16, 2022
wcy-fdu
approved these changes
Nov 17, 2022
wenym1
approved these changes
Nov 17, 2022
src/storage/src/table/mod.rs
Outdated
| iter: I, | ||
| } | ||
|
|
||
| impl<I: StateStoreIter<Item = (FullKey<Vec<u8>>, Bytes)>> StateStoreIter |
There was a problem hiding this comment.
Can we try implementing a map method for StateStoreIter by adding a trait named like StateStoreIterMapExt?
Li0k
approved these changes
Nov 17, 2022
xxchan
pushed a commit
that referenced
this pull request
Nov 19, 2022
* remove all functions in keyspace * remove keyspace * misc * revert version.rs * rename store to local_store in streaming table * replace ExtractTableKeyIterator with a more general interface Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
After #6130, keys are no longer "globally unique" - keys of different operators are distinguished by different
table_ids in the read/write option when calling state store interface. Thetable_idprefix is no longer required, makingKeySpacea redundant layer. So this PR removes it.ExtractTableKeyIteris moved to table/mod.rs, and is constructed inStorageIterInnerChecklist
- [ ] I have added necessary unit tests and integration tests./risedev check(or alias,./risedev c)Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.
Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)