fix(storage): fix wrong parameter of hit_sstable_bloom_filter #6400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gun9niR
approved these changes
Nov 16, 2022
Codecov Report
@@ Coverage Diff @@
## main #6400 +/- ##
==========================================
- Coverage 74.28% 74.07% -0.21%
==========================================
Files 960 966 +6
Lines 156525 157887 +1362
==========================================
+ Hits 116277 116962 +685
- Misses 40248 40925 +677
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xxchan
pushed a commit
that referenced
this pull request
Nov 19, 2022
* fix(storage): fix wrong parameter of hit_sstable_bloom_filter * fix(storage): fix typo Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
After merge #6130, we found some wrong when using state_store_v1 backend.
This PR fix wrong parameter of
hit_sstable_bloom_filterand reduceUserKey::encodetimesPlease explain IN DETAIL what the changes are in this PR and why they are needed:
hit_sstable_bloom_filterUserKey::for_testin state_storeUserKey::encodetimesChecklist
[ ] I have written necessary rustdoc comments[ ] I have added necessary unit tests and integration tests./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)