Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): Stronger requirement on input range for iter and scan in StateStore #6147

Closed
wants to merge 2 commits into from

Conversation

jon-chuang
Copy link
Contributor

@jon-chuang jon-chuang commented Nov 1, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Stronger requirement on input range for iter and scan in StateStore

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Fix: #6104

@github-actions github-actions bot added the type/fix Bug fix label Nov 1, 2022
@jon-chuang jon-chuang requested review from Li0k, StrikeW and wenym1 November 1, 2022 06:43
@wenym1
Copy link
Contributor

wenym1 commented Nov 1, 2022

#6130 is working on a refactor on full key. After this refactor, the passed in key will not be prefixed with table id anymore, and then we will have enforced such requirement in our interface and does not need to introduce extra check.

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #6147 (3069c61) into main (a3fac7f) will increase coverage by 0.01%.
The diff coverage is 93.19%.

@@            Coverage Diff             @@
##             main    #6147      +/-   ##
==========================================
+ Coverage   74.82%   74.83%   +0.01%     
==========================================
  Files         931      931              
  Lines      148973   149120     +147     
==========================================
+ Hits       111467   111594     +127     
- Misses      37506    37526      +20     
Flag Coverage Δ
rust 74.83% <93.19%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/storage/src/hummock/state_store.rs 24.65% <ø> (ø)
src/storage/src/store.rs 30.00% <ø> (ø)
.../storage/hummock_test/src/hummock_storage_tests.rs 94.83% <93.19%> (-0.24%) ⬇️
src/batch/src/executor/group_top_n.rs 68.07% <0.00%> (-6.63%) ⬇️
src/connector/src/source/filesystem/file_common.rs 80.80% <0.00%> (+0.44%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jon-chuang jon-chuang closed this Nov 1, 2022
@xxchan xxchan deleted the jon/prefix_table_id branch May 14, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug(storage): StateStore::iter() interface doesn't filter rows correctly
2 participants