Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(expr): optimize to_char function with constant template #5130

Merged
merged 8 commits into from
Sep 6, 2022

Conversation

TennyZhuang
Copy link
Contributor

Signed-off-by: TennyZhuang [email protected]

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Optimize to_char

We may need more expression template for context :)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Signed-off-by: TennyZhuang <[email protected]>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 2109 files.

Valid Invalid Ignored Fixed
1025 1 1083 0
Click to see the invalid file list
  • src/expr/src/expr/expr_to_char_const_tmpl.rs

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: TennyZhuang <[email protected]>
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #5130 (c06327d) into main (a14d883) will decrease coverage by 0.09%.
The diff coverage is 48.18%.

@@            Coverage Diff             @@
##             main    #5130      +/-   ##
==========================================
- Coverage   74.21%   74.11%   -0.10%     
==========================================
  Files         882      883       +1     
  Lines      134837   135323     +486     
==========================================
+ Hits       100069   100298     +229     
- Misses      34768    35025     +257     
Flag Coverage Δ
rust 74.11% <48.18%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/hash_agg.rs 93.08% <ø> (-0.03%) ⬇️
src/common/src/error.rs 72.19% <ø> (ø)
src/compute/src/rpc/service/stream_service.rs 0.00% <0.00%> (ø)
src/compute/src/server.rs 0.00% <0.00%> (ø)
src/expr/src/error.rs 25.00% <ø> (ø)
src/expr/src/expr/build_expr_from_prost.rs 55.51% <0.00%> (-2.48%) ⬇️
src/expr/src/expr/expr_to_char_const_tmpl.rs 0.00% <0.00%> (ø)
src/expr/src/expr/mod.rs 48.93% <ø> (ø)
src/expr/src/vector_op/to_char.rs 0.00% <0.00%> (ø)
src/frontend/src/handler/create_source.rs 78.94% <0.00%> (-14.81%) ⬇️
... and 50 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit 5fd012d into main Sep 6, 2022
@mergify mergify bot deleted the perf/optimize-to-char-with-const-template branch September 6, 2022 07:11
@BugenZhao BugenZhao mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants