-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(expr): optimize to_char function with constant template #5130
Conversation
Signed-off-by: TennyZhuang <[email protected]>
Signed-off-by: TennyZhuang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 2109 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
1025 | 1 | 1083 | 0 |
Click to see the invalid file list
- src/expr/src/expr/expr_to_char_const_tmpl.rs
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Tao Wu <[email protected]>
Co-authored-by: Bugen Zhao <[email protected]>
Signed-off-by: TennyZhuang <[email protected]>
…-with-const-template
Signed-off-by: TennyZhuang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #5130 +/- ##
==========================================
- Coverage 74.21% 74.11% -0.10%
==========================================
Files 882 883 +1
Lines 134837 135323 +486
==========================================
+ Hits 100069 100298 +229
- Misses 34768 35025 +257
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: TennyZhuang [email protected]
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Optimize
to_char
We may need more expression template for context :)
Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)