Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(optimizer, stream): support index selection for temporal join #11019

Merged
merged 4 commits into from
Jul 19, 2023

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Jul 18, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Example:

create table stream(id1 int, a1 int, b1 int) APPEND ONLY;
create table version(id2 int, a2 int, b2 int, primary key (id2));
create index idx on version (a2);
CREATE materialized VIEW v AS
SELECT id1,
       a1,
       id2,
       a2
FROM stream
LEFT JOIN idx
FOR SYSTEM_TIME AS OF PROCTIME() ON b1 = b2
AND a1 = a2;

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR contains user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • SQL commands, functions, and operators

Release note

  • Support index selection for temporal join.

@chenzl25 chenzl25 added the user-facing-changes Contains changes that are visible to users label Jul 18, 2023
@chenzl25 chenzl25 requested review from xxchan, fuyufjh and st1page July 18, 2023 08:41
Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #11019 (988bae2) into main (ddc7c27) will decrease coverage by 0.01%.
The diff coverage is 59.01%.

@@            Coverage Diff             @@
##             main   #11019      +/-   ##
==========================================
- Coverage   69.89%   69.89%   -0.01%     
==========================================
  Files        1312     1312              
  Lines      224186   224232      +46     
==========================================
+ Hits       156702   156734      +32     
- Misses      67484    67498      +14     
Flag Coverage Δ
rust 69.89% <59.01%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor/temporal_join.rs 0.00% <0.00%> (ø)
src/stream/src/from_proto/temporal_join.rs 0.00% <0.00%> (ø)
...c/frontend/src/optimizer/plan_node/logical_join.rs 90.83% <94.59%> (+0.06%) ⬆️
src/common/src/catalog/physical_table.rs 92.72% <100.00%> (+0.13%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chenzl25 chenzl25 enabled auto-merge July 19, 2023 07:52
@chenzl25 chenzl25 added this pull request to the merge queue Jul 19, 2023
Merged via the queue into main with commit 7ae9b81 Jul 19, 2023
@chenzl25 chenzl25 deleted the dylan/support_index_selection_for_temporal_join branch July 19, 2023 08:30
@emile-00 emile-00 added the 📖✓ Covered or will be covered in the user docs. label Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users 📖✓ Covered or will be covered in the user docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants