Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: investigate the performance of DataChunkBuilder #9301

Open
Tracked by #7289
lmatz opened this issue Apr 20, 2023 · 3 comments
Open
Tracked by #7289

perf: investigate the performance of DataChunkBuilder #9301

lmatz opened this issue Apr 20, 2023 · 3 comments

Comments

@lmatz
Copy link
Contributor

lmatz commented Apr 20, 2023

Proposed by @BugenZhao @st1page

@kwannoel
Copy link
Contributor

kwannoel commented Apr 20, 2023

Any specific directions or existing evidence that this can be further optimized?

  • For instance does it show up on q17 flamegraph?
  • Or if a benchmark doesn't currently exist, but we suspect DataChunkBuilder might not be that performant, what should be the spec of the benchmark?
  • Or some other observation?

@lmatz
Copy link
Contributor Author

lmatz commented Apr 20, 2023

The motivation comes from #9300 instead of observation.

If building a new chunk is slow, then the optimization discussed in #9300 leads to unfair comparison and thus we could make a completely different conclusion regarding whether #9300 improves performance or not.

@lmatz lmatz removed this from the release-0.19 milestone May 12, 2023
@github-actions
Copy link
Contributor

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants