Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add distinct agg support to replace 2-phase rewriting #7682

Closed
Tracked by #7289
stdrc opened this issue Feb 3, 2023 · 0 comments · Fixed by #8100
Closed
Tracked by #7289

feat: add distinct agg support to replace 2-phase rewriting #7682

stdrc opened this issue Feb 3, 2023 · 0 comments · Fixed by #8100
Assignees
@stdrc
Labels
type/feature
Milestone
release-0.18

Comments

@stdrc
Copy link
Member

stdrc commented Feb 3, 2023

As discussed in #7271 (comment).
@github-actions github-actions bot added this to the release-0.1.17 milestone Feb 3, 2023
@stdrc stdrc mentioned this issue Feb 6, 2023
Closed
@lmatz lmatz mentioned this issue Feb 6, 2023
Open
54 tasks
@stdrc stdrc mentioned this issue Feb 8, 2023
Merged
5 tasks
@xiangjinwu xiangjinwu mentioned this issue Feb 10, 2023
Closed
@stdrc stdrc changed the title feat: add distinct aggregator to substitute for 2-phase distinct agg rewriting feat: add distinct agg support to replace 2-phase distinct agg rewriting Feb 15, 2023
@stdrc stdrc changed the title feat: add distinct agg support to replace 2-phase distinct agg rewriting feat: add distinct agg support to replace 2-phase rewriting Feb 15, 2023
@stdrc stdrc modified the milestones: release-0.1.17, release-0.1.18 Feb 15, 2023
@stdrc stdrc mentioned this issue Feb 21, 2023
Merged
7 tasks
@mergify mergify bot closed this as completed in #8100 Feb 24, 2023
mergify bot pushed a commit that referenced this issue Feb 24, 2023
@stdrc
feat(stream,agg): enable distinct agg support in backend (#8100)
3c5bf28 
Previously in #7797, distinct agg support is added (without cache) but not enabled. This PR enables it by disable 2-phase rewrite rule for streaming distinct agg calls, and also adds an LRU cache in the deduplicater.

This will close #7682, and possibly resolve or at least mitigate the performance issue in #7350 and #7271.

Approved-By: st1page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stdrc stdrc

Labels
type/feature
Projects
None yet
Milestone
release-0.18
Development

Successfully merging a pull request may close this issue.

feat(stream,agg): enable distinct agg support in backend risingwavelabs/risingwave
1 participant
@stdrc