Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow jemalloc on macOS? #7358

Closed
ice1000 opened this issue Jan 12, 2023 · 3 comments
Closed

Allow jemalloc on macOS? #7358

ice1000 opened this issue Jan 12, 2023 · 3 comments
Assignees
@ice1000
Labels
Invalid PR Title no-issue-activity

Comments

@ice1000
Copy link
Contributor

ice1000 commented Jan 12, 2023

The jemalloc issue only mentions the compilation problem on Windows. Should we also allow jemalloc on macOS?

Does tikv jemalloc support macOS? Because I'm not sure about that.

Yes. It works fine on macOS since the first day we add jemalloc.

Originally posted by @yuhao-su in #7305 (comment)
@ice1000 ice1000 self-assigned this Jan 12, 2023
@github-actions github-actions bot added this to the release-0.1.16 milestone Jan 12, 2023
@fuyufjh fuyufjh removed this from the release-0.1.16 milestone Jan 30, 2023
@liurenjie1024
Copy link
Contributor

In general I have not bias toward it, but there is one problem with jemalloc on macos(it reports incorrect memory usage):
#7180 (comment)

So given that it may cause misunderstanding, I would prefer not to enable it.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

@BugenZhao
Copy link
Member

Enabled without ctl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ice1000 ice1000

Labels
Invalid PR Title no-issue-activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@liurenjie1024 @fuyufjh @ice1000 @BugenZhao