Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimization: StreamHashJoin can fill cache on write directly without read when the join key contains input_pk #7290

Closed
Tracked by #7289
st1page opened this issue Jan 10, 2023 · 1 comment
Closed
Tracked by #7289

optimization: StreamHashJoin can fill cache on write directly without read when the join key contains input_pk #7290

st1page opened this issue Jan 10, 2023 · 1 comment
Assignees
@yuhao-su
Labels
type/perf
Milestone
release-0.1.17

Comments

@st1page
Copy link
Contributor

st1page commented Jan 10, 2023

Maybe it is a little improvement but very general when join the dim table with pk in snowflake model or star model
such as nexmark q3, q4, q6, q8, q20
@github-actions github-actions bot added this to the release-0.1.16 milestone Jan 10, 2023
@st1page st1page changed the title optimization: StreamHashJoin can fill cache on write without read when the join key contains input_pk optimization: StreamHashJoin can fill cache on write directly without read when the join key contains input_pk Jan 10, 2023
@lmatz lmatz mentioned this issue Jan 10, 2023
Open
54 tasks
@lmatz
Copy link
Contributor

lmatz commented Feb 16, 2023

seems done

risingwave/src/stream/src/executor/managed_state/join/mod.rs

Line 462 in 03c26b0

} else if self.pk_contained_in_jk {

@lmatz lmatz closed this as completed Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuhao-su yuhao-su

Labels
type/perf
Projects
None yet
Milestone
release-0.1.17
Development

No branches or pull requests
4 participants
@lmatz @fuyufjh @yuhao-su @st1page