Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grafana does not show all nodes in Dashboard #6448

Closed
CAJan93 opened this issue Nov 17, 2022 · 10 comments
Closed

Grafana does not show all nodes in Dashboard #6448

CAJan93 opened this issue Nov 17, 2022 · 10 comments
Assignees
Labels

Comments

@CAJan93
Copy link
Contributor

CAJan93 commented Nov 17, 2022

Describe the bug

I started the setup with multiple ETCD and meta nodes (see this PR). the Node Count does not list all the node. It omits the ETCD and the meta nodes. Is this on purpose? Could we change this please?

Screenshot from Grafana. I started a new cluster using the multi-node setup at 14:40.

Screenshot 2022-11-17 at 14 41 36

Expected behavior

Node Count should list all nodes in the cluster.

@CAJan93 CAJan93 added type/bug Something isn't working type/feature labels Nov 17, 2022
@github-actions github-actions bot added this to the release-0.1.15 milestone Nov 17, 2022
@Gun9niR Gun9niR assigned Gun9niR and unassigned Gun9niR Nov 18, 2022
@Gun9niR
Copy link
Contributor

Gun9niR commented Nov 18, 2022

Will #5943 modify ClusterManager to track MetaNode?

@CAJan93
Copy link
Contributor Author

CAJan93 commented Nov 22, 2022

Will #5943 modify ClusterManager to track MetaNode?

I don't think that that is in the scope. Maybe we should keep this as its own backlog item. What do you think?

@Gun9niR
Copy link
Contributor

Gun9niR commented Nov 22, 2022

Ok. As long as each meta node can be notified of other meta nodes' existence, we can track MetaNode in Grafana. But for third-party dependencies such as etcd, I don't think it's the developer dashboard's job to track them, because:

  • Not all third-party components offer a way to monitor the number of instances. Even if they do, the methods might differ a lot, requiring distinct code logic for each.
  • The developer dashboard is mainly for profiling and debugging RisingWave's own nodes, i.e. compute/frontend/compactor/meta node. Normally, we shouldn't expect failures from third-party components, so tracking them would be unnecessary.

@CAJan93
Copy link
Contributor Author

CAJan93 commented Nov 23, 2022

Why does a meta node need to be informed about the other nodes existence?

@skyzh
Copy link
Contributor

skyzh commented Nov 24, 2022

Third party nodes are not included. We only count RisingWave components here.

@fuyufjh
Copy link
Member

fuyufjh commented Nov 28, 2022

Before HA Meta we only have 1 meta node.

@fuyufjh fuyufjh assigned yezizp2012 and unassigned Gun9niR Nov 28, 2022
@CAJan93
Copy link
Contributor Author

CAJan93 commented Nov 28, 2022

Third party nodes are not included. We only count RisingWave components here.

Meta counts as third party? Is this dashboard only about "kernel"? Should we not also keep track of meta nodes? They are vital for our service.

@yezizp2012
Copy link
Member

Third party nodes are not included. We only count RisingWave components here.

Meta counts as third party? Is this dashboard only about "kernel"? Should we not also keep track of meta nodes? They are vital for our service.

Meta should need to be taken into account, ETCD does not. I believe after HA Meta we should track meta nodes as well in the dashboard. All meta nodes should be queryable from any meta nodes and managed by ClusterManager. I think this should be naturally supported in HA Meta.

@Gun9niR
Copy link
Contributor

Gun9niR commented Nov 28, 2022

Meta should need to be taken into account, ETCD does not.

The kernel includes compute/compactor/meta/frontend nodes.

I believe after HA Meta we should track meta nodes as well in the dashboard. All meta nodes should be queryable from any meta nodes and managed by ClusterManager. I think this should be naturally supported in HA Meta.

This is what I mean by

As long as each meta node can be notified of other meta nodes' existence, we can track MetaNode in Grafana.

@yezizp2012
Copy link
Member

Will be handled in #7576 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants