Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discussion: replace minstant and minitrace with the standard instant and tracing library #10236

Closed
hzxa21 opened this issue Jun 8, 2023 · 4 comments · Fixed by #10417
Closed

Discussion: replace minstant and minitrace with the standard instant and tracing library #10236

hzxa21 opened this issue Jun 8, 2023 · 4 comments · Fixed by #10417
Labels
type/feature
Milestone
release-1.0

Comments

@hzxa21
Copy link
Collaborator

hzxa21 commented Jun 8, 2023

minitrace relies on minstant.

We have seen two issues related to the portability of minstant in different platforms: #4547 and #10235.

IMO, the bottleneck won't be in the tracing and timing library in a foreseeable future. Fixing ande debugging portability issues in minstant and potentially minitrace can be a headache. I suggest we consider using more widely used libraries like tokio tracing and std time instead.

Discussions are welcomed.
@github-actions github-actions bot added this to the release-0.20 milestone Jun 8, 2023
@liurenjie1024
Copy link
Contributor

We had a discussion here: #5015

I think tracing has better ecosystem, so +1 for tracing library.

@BugenZhao
Copy link
Member

BugenZhao commented Jun 8, 2023 •
edited
Loading

Related: #10000

I think tracing has better ecosystem, so +1 for tracing library.

@hzxa21 hzxa21 mentioned this issue Jun 13, 2023
Merged
7 tasks
@neverchanje
Copy link
Contributor

Do we have any remaining issue regarding minstant/minitrace?

@BugenZhao
Copy link
Member

Do we have any remaining issue regarding minstant/minitrace?

After #10417, all related stuff will be cleaned-up.

@BugenZhao BugenZhao mentioned this issue Jun 21, 2023
Merged
4 tasks
@niebayes niebayes mentioned this issue Aug 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/feature
Projects
None yet
Milestone
release-1.0
Development

Successfully merging a pull request may close this issue.

feat(tracing): replace Jaeger with Tempo & integrate it with Grafana risingwavelabs/risingwave
4 participants
@liurenjie1024 @hzxa21 @neverchanje @BugenZhao