-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support block building mode #368
Comments
Commit kien-rise@f9ec57d is actually independent and good to merge. By returning Shall I create a PR containing this commit alone? For commit kien-rise@bc95f3f, I only remember it is there to avoid Since the |
Wouldn't kien-rise@f9ec57d fail tests as now some mainnet blocks assert a fallback error against valid sequential results? We also need to understand why users like block builders need a sequential fallback in the first place. If the original problems have better solutions then we should avoid this expensive fallback. For instance, per the already checked-in comments, we should skip unsound-nonce transactions right within For kien-rise@bc95f3f, we should still inspect the actual problems and find a better solution than sequential fallback. Depending on the mempool or block builder's behaviors not to deadlock is not good. Ideally |
We need better solutions for these:
The text was updated successfully, but these errors were encountered: