-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin jsonschema to v1.2.2 #882
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very strange. lgtm!
Hey Guys, any update on this. Currently, ripple-lib is broken because of this.
I used to hate Maven for not allowing me to upgrade automatically in case of a patch release. And these kind of issues, puts faith in Java ecosystem. I earlier faced a similar issue with Mongoose library, and swear to God, I removed all those funny symbols (~ or ^) from all the repos which I had access to in my organization. Unknowingly I was living a better life. |
@enVolt I appreciate that you've let us know that this issue is also affecting you. I'll merge it now and do a release. Thanks! |
The fix is included in 0.20.0. Please create an issue if you still notice any problems. Thank you! |
@enVolt @intelliot I'm still waiting on confirmation that using a correct URI fixes the application. Please see tdegrunt/jsonschema#253 |
Did a little digging here, and found that in the new update |
@FKSRipple If it's an error related to tdegrunt/jsonschema#253 and you can put together a test case, I'd be happy to consider adding it |
yarn upgrade
to updateyarn.lock
I believe these are already the dependencies that would be used by ripple-lib consumers, so there's no additional risk/harm in updating
yarn.lock
here. There's still risk that dependencies could introduce breaking changes at any time; I think we should address this by reducing our number of dependencies and by pinning more dependencies to specific versions (don't use^
or~
).