Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin jsonschema to v1.2.2 #882

Merged
merged 1 commit into from
Apr 9, 2018
Merged

Pin jsonschema to v1.2.2 #882

merged 1 commit into from
Apr 9, 2018

Conversation

intelliot
Copy link
Collaborator

@intelliot intelliot commented Apr 3, 2018

I believe these are already the dependencies that would be used by ripple-lib consumers, so there's no additional risk/harm in updating yarn.lock here. There's still risk that dependencies could introduce breaking changes at any time; I think we should address this by reducing our number of dependencies and by pinning more dependencies to specific versions (don't use ^ or ~).

Copy link
Contributor

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very strange. lgtm!

@enVolt
Copy link

enVolt commented Apr 9, 2018

Hey Guys, any update on this. Currently, ripple-lib is broken because of this.

I think we should address this by reducing our number of dependencies and by pinning more dependencies to specific versions (don't use ^ or ~)

I used to hate Maven for not allowing me to upgrade automatically in case of a patch release. And these kind of issues, puts faith in Java ecosystem.

I earlier faced a similar issue with Mongoose library, and swear to God, I removed all those funny symbols (~ or ^) from all the repos which I had access to in my organization. Unknowingly I was living a better life.

@intelliot
Copy link
Collaborator Author

@enVolt I appreciate that you've let us know that this issue is also affecting you. I'll merge it now and do a release. Thanks!

@intelliot intelliot merged commit e0eb27e into develop Apr 9, 2018
@intelliot intelliot deleted the jsonschema-v1.2.2 branch April 9, 2018 18:54
@intelliot
Copy link
Collaborator Author

The fix is included in 0.20.0. Please create an issue if you still notice any problems. Thank you!

@awwright
Copy link

awwright commented Apr 9, 2018

@enVolt @intelliot I'm still waiting on confirmation that using a correct URI fixes the application. Please see tdegrunt/jsonschema#253

@FKSRipple
Copy link
Collaborator

Did a little digging here, and found that in the new update schemas seems to have changed from a title->schema structure to a more complex data-structure, with nesting (ex: `'/signParameters#/properties/keypair' is a title in the schemas object with the latest version). This seems to have caused our issue.

@awwright
Copy link

@FKSRipple If it's an error related to tdegrunt/jsonschema#253 and you can put together a test case, I'd be happy to consider adding it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SchemaError: no such schema </tag>
5 participants