Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getAccountObjects #881

Merged
merged 3 commits into from
Apr 11, 2018
Merged

Add getAccountObjects #881

merged 3 commits into from
Apr 11, 2018

Conversation

intelliot
Copy link
Collaborator

Add getAccountObjects to implement the rippled account_objects command.

See https://ripple.com/build/rippled-apis/#account-objects

intelliot added 2 commits April 2, 2018 11:41
@intelliot
Add getAccountObjects
6fcc404 
Squashed commit of the following:

commit 232a0a3
commit 361ead8
commit 5ff26d7
commit 97f5dfc
commit d486540
commit 4790401
commit 57512f7
commit e75a7e9
commit 5deb6ff
commit 7e3c62d
commit 85834b6
@intelliot
Add GetAccountObjectsOptions
3173741 
Remove _validateRequest()
@intelliot intelliot mentioned this pull request Apr 2, 2018
Closed
@intelliot intelliot requested review from emschwartz and mDuo13 April 3, 2018 21:36
mDuo13
mDuo13 approved these changes Apr 3, 2018
View reviewed changes
Copy link
Collaborator

@mDuo13 mDuo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't actually compile & try it but at a glance it seems good.

src/common/types/objects/ledger_entries.ts Outdated
TickSize?: number,
TransferRate?: number,
Domain?: string
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick glance at the code tells me it may still be possible to get (and set!) WalletLocator and WalletSize fields with the AccountSet transaction. They've been marked deprecated for a long time, but still, may be better to have them here so you don't error out if you encounter one?

test/api-test.js Outdated
checkResult(responses.getAccountObjects, 'AccountObjectsResponse', response));
});

xit('request account_objects - multiple pages', function () {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this say "it" instead of "xit"?

@intelliot intelliot merged commit e978ef1 into develop Apr 11, 2018
@intelliot intelliot deleted the getAccountObjects-2 branch April 11, 2018 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mDuo13 mDuo13 mDuo13 approved these changes

@emschwartz emschwartz Awaiting requested review from emschwartz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@intelliot @mDuo13