Existing types cleanup + more api methods onto new request method #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- getPaymentChannel() now uses this.request() - getSettings() now uses this.request() - getLedger() now uses this.request() - transaction types cleaned up a bit, but still some work left to do - lots of other type cleanup as well
intelliot
reviewed
Mar 1, 2018
| @@ -0,0 +1,56 @@ | |||
| import {SignerEntry} from './index' | |||
|
|
|||
| export type PayChannelLedgerEntry = { | |||
There was a problem hiding this comment.
Why use type here instead of interface?
There was a problem hiding this comment.
@sublimator is right, that's a left over from Flow. Changing to interface...
|
Might be a leftover from Flow syntax :)
|
|
@sublimator is right, that's a left over from Flow. Changing to interface... |
intelliot
approved these changes
Mar 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ledger/types.ts,ledger/transaction-types.ts, etc.) cleaned up, but not yet completely moved to new system/cc @intelliot