-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate/publish *.ts.d #851
Conversation
They are very useful in developing stable applications with TypeScript.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1! Excited to see there's a desire for the consumer type declarations!
For background this wasn't turned off for any particular reason, just to keep the original move to TS simple. So 👍 for turning them on for the next release.
@FredKSchott How are declaration files typically used? Is it automatically parsed by editors like VS Code? |
Exactly, the definition files ( |
Fixes TypeScript compile errors: > Exported variable '…' has or is using private name '…'. These occur due to generating TS declaration files. See #851
Fixes TypeScript compile errors due to generating TS declaration files. See #851
Afaik, additionally [...]
"main": "dist/npm",
"name": "ripple-lib",
"types": "dist/npm/index.d.ts"
[...] See https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html Without this I always get Could not find a declaration file for module 'ripple-lib'. '../ripple-lib/dist/npm/index.js' implicitly has an 'any' type... error. (I have When I add |
@darkmemo good catch! |
They are very useful in developing stable applications with TypeScript.