[Docs] Improve escrow creation example to have ExecuteAfter date #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intelliot
approved these changes
Dec 19, 2017
intelliot
added a commit
that referenced
this pull request
Jan 17, 2018
- Request fixture was changed by #820 - Add an ExecuteAfter (aka FinishAfter) timestamp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing example of an escrowCreation transaction in the docs includes
allowCancelAfterbut not anallowExecuteAfterfield (and also no condition field)—this is the exact arrangement that can cause "false escrows" like the ones Ripple mistakenly made with the first set of the 55B escrows—they can be finished by anyone at any time before the cancellation.This PR edits the example test fixture to add an
allowExecuteAfterfield. This provides a better example, but should be functionally identical as a test fixture because the statedallowCancelAfterdate is still in the past.