Transaction updates #221
Merged
Transaction updates #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // We aren't clever enough to eschew preventative measures so we keep an array | ||
| // of all submitted transactionIDs (which can change due to load_factor | ||
| // effecting the Fee amount). This should be populated with a transactionID | ||
| // any time it goes on the network |
There was a problem hiding this comment.
I would keep comments for some of these properties. They might not be clear to other people browsing the code.
There was a problem hiding this comment.
Canonical signing setting defaults to the Remote's configuration should be obvious and so is this.submittedIDs. The comments in this case don't really provide more information than the code itself.
|
LGTM, please rebase before merging |
- Deprecate 'save' event - Add TransactionQueue.getMinLedger(), use this as ledger_index_min in account_tx request on reconnect - tx.sign() no longer accepts a callback - Add various setters and jsdoc to transaction.js - Normalize setters, e.g. sourceTag() and destinationTag() - Minor optimization in call to tx.hash() in TransactionManager prior to submit; allow `serialized` argument to tx.hash() such that the transaction is not serialized twice
Do not finalize tef or tel-class errors until LastLedgerSequence is exceeded. Transactions that fail in this way will now be aborted with a tej-class error. Errors like tefALREADY and tefMAX_LEDGER should now be opaque to the user and have no consequence in determining a final state.
geertweening
force-pushed
the
transaction-updates
branch
from
35b3881 to
1a892d5
Compare
ledhed2222
pushed a commit
that referenced
this pull request
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.