Request ledger_accept returns the Request, not Remote #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I doubt that it breaks the tests. Nice catch |
wltsmrz
added a commit
that referenced
this pull request
Nov 17, 2014
Request ledger_accept returns the Request, not Remote
|
👍 |
ledhed2222
pushed a commit
that referenced
this pull request
Nov 8, 2021
Bumps [bn.js](https://github.com/indutny/bn.js) from 5.1.2 to 5.1.3. - [Release notes](https://github.com/indutny/bn.js/releases) - [Changelog](https://github.com/indutny/bn.js/blob/master/CHANGELOG.md) - [Commits](indutny/bn.js@v5.1.2...v5.1.3) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found when testing on a standalone rippled that the
ledger_acceptfunction was returning the remote, leaving the caller no way to modify, or add additional event listeners to the request.This is probably a breaking change, but only against test code, since this function won't work against the "live" network.