Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RippledError #687

Closed
sublimator opened this issue Jan 12, 2016 · 0 comments
Closed

RippledError #687

sublimator opened this issue Jan 12, 2016 · 0 comments

Comments

@sublimator
Copy link
Contributor

sublimator commented Jan 12, 2016

https://github.com/ripple/ripple-lib/blob/develop/src/common/connection.js#L284-L285

        if (response.status === 'error') {
          _reject(new RippledError(response.error));

response.error is just a string token like invalidParams. I think it makes sense to just pass the whole response as the second parameter data to RippledError. There's no really escaping the fact that RippleAPI is built upon the existing rippled api, so when there's information about an error, it would be best to be able to access it.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/29801330-ripplederror?utm_campaign=plugin&utm_content=tracker%2F323756&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F323756&utm_medium=issues&utm_source=github).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants