Skip to content
This repository has been archived by the owner on Nov 24, 2021. It is now read-only.

Expand node version compatibility #32

Closed
intelliot opened this issue Aug 28, 2019 · 3 comments
Closed

Expand node version compatibility #32

intelliot opened this issue Aug 28, 2019 · 3 comments

Comments

@intelliot
Copy link
Contributor

package.json currently specifies "node": ">=10.0.0 <11.0.0". Look into supporting more versions of node, particularly versions 11 and 12.

@swansontec
Copy link
Contributor

swansontec commented Aug 29, 2019

Agreed.

The commit that restricted the version range is 4eb1f7d. This commit mentions the unit tests failing, which indeed they do.

Looking at the unit tests, they are doing things like assert.deepEqual(someUint8Array, [0, 1]). Of course this won't work - a regular Array and a Uint8Array are different types. So, the unit tests simply need to be updated to compare things of the correct type, and the problems will go away.

@swansontec
Copy link
Contributor

I have just submitted PR #33 to address this.

@intelliot
Copy link
Contributor Author

Fixed by #33

Released in 0.2.3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants