Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed options offset equals zero was't recognized #247

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Fixed options offset equals zero was't recognized #247

merged 1 commit into from
Apr 15, 2020

Conversation

veitbjarsch
Copy link
Contributor

@veitbjarsch veitbjarsch commented Apr 15, 2020 •
edited
Loading

This PR fixes the bug that the default value will be used if the options offset value was set to zero.

Example:

import VueScrollTo from 'vue-scrollto';

Vue.use(VueScrollTo, {
  offset: -30
});

this.$scrollTo('#idToScroll', { offset: 0 });

@rigor789 rigor789 merged commit 09ee3c4 into rigor789:master Apr 15, 2020
@rigor789
Copy link
Owner

Thanks!

@rigor789
Copy link
Owner

🎉 This PR is included in version 2.18.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@hroland hroland mentioned this pull request Oct 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@veitbjarsch @rigor789