Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check secret resource is changed before updating it #273

Closed
jenting opened this issue Jul 22, 2024 · 0 comments · Fixed by #274 or #275
Closed

Check secret resource is changed before updating it #273

jenting opened this issue Jul 22, 2024 · 0 comments · Fixed by #274 or #275

Comments

@jenting
Copy link
Contributor

jenting commented Jul 22, 2024

The Vault operator generates the k8s secret resource from the vault CR. Once the secret generated, the vault operator reconcile the Vault CR and updating the secret even the secret resource if the same.

We should compare the secret resource is changed before updating the secret. If the secrets without changing, bypass the update secret operations. This could decreasing the unnecessary kube-server Update API call as well as decreasing the ETCD DB size increase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant