Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined has joined the room. #106

Open
meeblo opened this issue Aug 25, 2014 · 2 comments
Open

undefined has joined the room. #106

meeblo opened this issue Aug 25, 2014 · 2 comments

Comments

@meeblo
Copy link

meeblo commented Aug 25, 2014

Problems with Facebook auth
User can join to room and i see only "undefined has joined the room."

@To-mos
Copy link

To-mos commented Feb 3, 2015

this is because the responce data from facebook no longer has the "username" attribute so anything with req.user.username needs to be corrected to handle facebooks "displayName" change. I fixed it by going through and adding

(req.user.provider == "facebook" ? req.user.displayName : req.user.username)

@curtlucas
Copy link

I have having this same issue, replacing .username with .DisplayName didn't seem to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants