Why doesn't TextArea implement Widget trait

[fmorroni]

Hi, why doesn't TextArea implement the Widget trait? I know we have the widget() method but that seems kind of unnecessary to me. Is there an advantage to having it that way?

[rhysd]

because Widget::render requires to move out self

[rhysd]

I noticed that &TextArea can implement Widget. It might be smarter.

impl<'a> Widget for &'a TextArea<'a> {
    // ...
}

// Usage
term.draw(|f| {
    f.render_widget(&textarea, f.size());
})?;

[fmorroni]

I noticed that &TextArea can implement Widget. It might be smarter.

impl<'a> Widget for &'a TextArea<'a> {
    // ...
}

// Usage
term.draw(|f| {
    f.render_widget(&textarea, f.size());
})?;

Yeah that's basically what I did for a vim input widget I'm making. Seems to work fine.

[rhysd]

@fmorroni Thanks for clarification. I'll consider this.

[rhysd]

This was included in v0.5.3 release.

[fmorroni]

This was included in v0.5.3 release.

Great thanks!

[evbo]

@rhysd did this break again recently?:

error[E0277]: the trait bound `&tui_textarea::textarea::TextArea<'_>: Widget` is not satisfied
  --> src/main.rs:72:30
   |
72 |         frame.render_widget(&self.state.text_area, area);
   |               -------------  ^^^^^^^^^^^^^^^^^^^^ the trait `widgets::WidgetRef` is not implemented for `&tui_textarea::textarea::TextArea<'_>`, which is required by `&tui_textarea::textarea::TextArea<'_>: Widget`
   |               |
   |               required by a bound introduced by this call

[rhysd]

@evbo This issue is a feature request and already closed. Could you create new one?