Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Workflows and Update Dependencies #479

Merged
merged 11 commits into from
Dec 9, 2023
Merged

Add Workflows and Update Dependencies #479

merged 11 commits into from
Dec 9, 2023

Conversation

CanerKaraca23
Copy link
Contributor

Added Dependabot and Gradle Wrapper Updater workflows to automatically detect dependency and Gradle wrapper updates and create pull requests to update them.

Updated some dependencies and Gradle wrapper.

Copy link
Collaborator

@authorisation authorisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks for making a PR
We don't really see the need for dependabot as it could cause potential issues, thanks for the suggestion though.
Have you tried compiling and running a build of this?
The Gradle Wrapper CI Script is also kind of useless in our opinion, it would just spam the action log and we'd rather update that manually aswell.

@authorisation authorisation self-assigned this Dec 7, 2023
@CanerKaraca23
Copy link
Contributor Author

CanerKaraca23 commented Dec 8, 2023

Hello, thanks for making a PR We don't really see the need for dependabot as it could cause potential issues, thanks for the suggestion though. Have you tried compiling and running a build of this? The Gradle Wrapper CI Script is also kind of useless in our opinion, it would just spam the action log and we'd rather update that manually aswell.

Hello, dependabot only creates PR for dependency updates, i updated android.yml so PRs will be tested if it cause potential issues and you can revert changes if there is an issue after merging PRs. Dependabot also not creates action log.
I have compiled and ran build of this, no issue.
Also i changed The Gradle Wrapper CI Script's schedule to monthly from daily, so it will not spam action log every day as you requested, and you can remove this schedule if you want because there is workflow_dispatch command you can use and bot automatically update Gradle Wrapper and make a PR for you.

Copy link
Contributor Author

@CanerKaraca23 CanerKaraca23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build passes.

Copy link
Collaborator

@authorisation authorisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, feel free to add yourself to the README.
Merging soon if you have nothing else to add.
Thanks for your contribution :)

@CanerKaraca23
Copy link
Contributor Author

Looks good, feel free to add yourself to the README. Merging soon if you have nothing else to add. Thanks for your contribution :)

Thanks! I added. I don't have anything to add, you can merge.

@CanerKaraca23
Copy link
Contributor Author

I also translated 100% of Turkish localization on Crowdin, can you add it too?

@authorisation authorisation added the stale Inactive label Dec 9, 2023
@authorisation authorisation removed the stale Inactive label Dec 9, 2023
@rhunk rhunk merged commit fc62f1b into rhunk:dev Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants