-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Workflows and Update Dependencies #479
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thanks for making a PR
We don't really see the need for dependabot as it could cause potential issues, thanks for the suggestion though.
Have you tried compiling and running a build of this?
The Gradle Wrapper CI Script is also kind of useless in our opinion, it would just spam the action log and we'd rather update that manually aswell.
Hello, dependabot only creates PR for dependency updates, i updated android.yml so PRs will be tested if it cause potential issues and you can revert changes if there is an issue after merging PRs. Dependabot also not creates action log. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build passes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, feel free to add yourself to the README.
Merging soon if you have nothing else to add.
Thanks for your contribution :)
Thanks! I added. I don't have anything to add, you can merge. |
I also translated 100% of Turkish localization on Crowdin, can you add it too? |
Added Dependabot and Gradle Wrapper Updater workflows to automatically detect dependency and Gradle wrapper updates and create pull requests to update them.
Updated some dependencies and Gradle wrapper.