Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid wiping quickfix list on :RescriptFormat #52

Open
sinap-fb opened this issue Aug 22, 2021 · 1 comment
Open

Avoid wiping quickfix list on :RescriptFormat #52

sinap-fb opened this issue Aug 22, 2021 · 1 comment

Comments

@sinap-fb
Copy link

sinap-fb commented Aug 22, 2021

(This probably applies to the :RescriptBuild command as well)

On format, the users quickfix list should not be wiped, since it can be a list of stuff unrelated to Rescript.

Currently, it is getting wiped here:

call setqflist([])

I think this should be achievable using quickfix IDs.

Thanks

@ryyppy
Copy link
Member

ryyppy commented Aug 28, 2021

yeah, i made this because I didn't know how to isolate quickfix results to certain scope. Didn't know about ids... currently I don't consider this a very big problem (except for wiping e.g. build errors from quickfix.. but for that I usually just rerun the build real quick with a hotkey).

Don't have much time right now to fix this right away, so I would be open for a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants