Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine many Image components into one struct ImageFormat #7051

Closed
emilk opened this issue Aug 5, 2024 · 0 comments · Fixed by #7083
Closed

Combine many Image components into one struct ImageFormat #7051

emilk opened this issue Aug 5, 2024 · 0 comments · Fixed by #7083
Assignees
Labels
enhancement New feature or request

Comments

@emilk
Copy link
Member

emilk commented Aug 5, 2024

See #6386 (comment) for more

archetype Image {
	buffer: ImageBuffer,
	format: ImageFormat
}

archetype SegmentationImage {
	buffer: ImageBuffer,
	format: ImageFormat,
}

archetype DepthImage {
	// Required:
	buffer: ImageBuffer,
	format: ImageFormat,
	
	meter: Optional<…>,
	colormap: Optional<…>,
}

component ImageFormat {
	datatype ImageFormat;
}

datatype ImageFormat {
	width: uint,
	height: uint,

	pixel_format: Optional<PixelFormat>, // Optional or not?
	color_model: Option<ColorModel>, // used if pixel_format = ARRAY
	datatype: Option<ChannelDatatype> // used if pixel_format = ARRAY
}

component enum PixelFormat {
    /// See `ColorModel` and `ChannelDatatype` instead
	ARRAY,

	RGB_565,
	RGBA_8888,
	NV12,
	YUY2,
	…
}
@emilk emilk added enhancement New feature or request 👀 needs triage This issue needs to be triaged by the Rerun team and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Aug 5, 2024
@emilk emilk added the blocked can't make progress right now label Aug 5, 2024
@jleibs jleibs self-assigned this Aug 5, 2024
@emilk emilk removed the blocked can't make progress right now label Aug 7, 2024
@jleibs jleibs closed this as completed in 4d3afcb Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants