Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

https tests fail on 0.8 #277

Closed
max-mapper opened this issue Jul 1, 2012 · 5 comments
Closed

https tests fail on 0.8 #277

max-mapper opened this issue Jul 1, 2012 · 5 comments

Comments

@max-mapper
Copy link 

$ node test-https.js
boundary >> 1C1C4C2B-9412-4854-A4C5-AC537FAA4005
--1C1C4C2B-9412-4854-A4C5-AC537FAA4005
content-type: text/html

<html><body>Oh hi.</body></html>
--1C1C4C2B-9412-4854-A4C5-AC537FAA4005

Oh hi.
--1C1C4C2B-9412-4854-A4C5-AC537FAA4005-- --frontier
content-type: text/html

<html><body>Oh hi.</body></html>
--frontier

Oh hi.
--frontier--

assert.js:104
  throw new assert.AssertionError({
        ^
AssertionError: "--1C1C4C2B-9412-4854-A4C5-AC537FAA4005\r\ncontent-type: text/html\r\n\r\n<html><body>Oh hi.</body></html>\r\n--1C1C4C2B-9412-48 == "--frontier\r\ncontent-type: text/html\r\n\r\n<html><body>Oh hi.</body></html>\r\n--frontier\r\n\r\nOh hi.\r\n--frontier--"

I was trying to hit the github API over HTTPS and kept get 500s even though curl worked with the same headers/body so I found these failures. Maybe they're related to my github API 500s?
@benatkin
Copy link
Contributor

benatkin commented Jul 5, 2012

Error reproduced on both of these versions of node:

(mbp) ~/github/mikeal/request $ nodebrew list
v0.6.19
v0.8.1

current: v0.8.1
(mbp) ~/github/mikeal/request $

So it isn't specific to 0.6.

@benatkin
Copy link
Contributor

benatkin commented Jul 5, 2012

This particular problem is with the test. It uses a UUID for the boundary, as of 2 months ago.

fc13e18

This makes it so the text from the test, last updated by @jhs on 2011-12-02, doesn't match up.

https://github.com/mikeal/request/blob/master/tests/test-https.js

@benatkin
Copy link
Contributor

benatkin commented Jul 5, 2012

Oops wrong commit.

69d017d

That's where the 'frontier' thing is coming from though.

@benatkin benatkin mentioned this issue Jul 5, 2012
Merged
@mikeal
Copy link
Member

mikeal commented Jul 25, 2012

fixed. with that pull req.

@mikeal mikeal closed this as completed Jul 25, 2012
@lerouxb
Copy link

lerouxb commented Aug 17, 2012

You might want to bump the version of the npm package so that https requests work in recent versions of node without package.json voodoo. ;)

(This isn't part of 2.9.203)

@niklabh niklabh mentioned this issue Jun 29, 2022
Open
@snyk-bot snyk-bot mentioned this issue Jun 29, 2022
Open
@grnd grnd mentioned this issue Jun 29, 2022
Open
@enterstudio enterstudio mentioned this issue Jun 30, 2022
Open
@snyk-bot snyk-bot mentioned this issue Jun 30, 2022
Open
@gjvis gjvis mentioned this issue Jul 31, 2022
Open
@gjvis gjvis mentioned this issue Sep 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mikeal @benatkin @max-mapper @lerouxb