Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove scss from code inside blockquote #5895

Closed
wants to merge 1 commit into from
Closed

fix: remove scss from code inside blockquote #5895

wants to merge 1 commit into from

Conversation

uyu423
Copy link

@uyu423 uyu423 commented Nov 25, 2022 •
edited
Loading

@auto-assign auto-assign bot requested a review from NGPixel November 25, 2022 21:36
@NGPixel
Copy link
Member

NGPixel commented Nov 25, 2022

While that may fix code blocks, you're now breaking inline code. Your PR should address both, not one in favor of the other.

@uyu423
Copy link
Author

uyu423 commented Nov 26, 2022 •
edited
Loading

Hi @NGPixel.

I tested the inline code markdown syntax you mentioned.
But I don't know what kind of "breaking" you're talking about.
I attach two screenshots. One is the original version, and one is my PR version.

If I missed something please tell me again.

I am using your wikijs project very well.
Thank you

original

image

in my PR

image

@uyu423
Copy link
Author

uyu423 commented Dec 22, 2022

@NGPixel hello?

@Nyxtorm Nyxtorm mentioned this pull request Jan 31, 2023
Merged
@NGPixel
Copy link
Member

NGPixel commented Feb 17, 2023

Closing in favor of #6108

@NGPixel NGPixel closed this Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NGPixel NGPixel Awaiting requested review from NGPixel

Assignees

@NGPixel NGPixel

Labels
needs-work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uyu423 @NGPixel