-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAuth2 authentication implementation #3094
Conversation
This PR shoul fix requarks#2392. Used `passport-oauth2` strategy.
Hi! What needs to happen to have this merged? Is there some way I could test this if I run wikijs from docker? |
@markspolakovs I think you can connect to docker and just copy those new files to your instance |
This is great and a proper OAuth2 integration :) Today's OIDC module doesn't for most OAuth2 handlers that are not strictly OpenID with the hardcoded scoped fields it requires, and I like that we can adjust the scope in properties here, that solves all the problems we've had. |
What is the current status? |
Is there any chance to get it merged soon? |
You can use docker image |
Took me a good hour to find this information, so putting it here: To use Nextcloud as OAuth2 Provider for wikijs, these are the correct settings: ID Claim: Display Name Claim: Email Claim: Otherwise you might end up with an error like |
Hi, I'm trying the same, where did you put these settings, the UI only shows me the emailClaim field (version 2.5.268) And how does your UserInfoEndpoiuntURI look like "https://cloud.my.com/ocs/v1.php/cloud/users?format=json" ? |
In Wiki.js 2.5.268, using the new |
Thank you very much, It works now. I had to add a new "Generic OAuth2" strategy in order to see the additional input fields. |
* OAuth2 authentication implementation This PR shoul fix requarks#2392. Used `passport-oauth2` strategy. * indentations cleanup * cleanup code
This PR shoul fix #2392. To implement OAuth2 authentication I've used
passport-oauth2
strategy.Tested with my own Nextcloud instance.