Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsonata): validation, caching, better logging #31832

Merged
merged 14 commits into from
Oct 8, 2024
Merged

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Oct 7, 2024

Changes

Adds caching to jsonata expression compiling. Also elevated logging to warn

Context

Important for #31826 to use afterwards

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested review from viceice and secustor October 7, 2024 16:00
@rarkins rarkins enabled auto-merge October 7, 2024 16:00
lib/util/jsonata.ts Outdated Show resolved Hide resolved
lib/util/jsonata.ts Show resolved Hide resolved
lib/modules/datasource/custom/index.ts Show resolved Hide resolved
viceice
viceice previously approved these changes Oct 7, 2024
@rarkins rarkins changed the title feat: jsonata caching, better logging refactor: jsonata caching, better logging Oct 8, 2024
viceice
viceice previously approved these changes Oct 8, 2024
lib/util/jsonata.ts Show resolved Hide resolved
@rarkins rarkins changed the title refactor: jsonata caching, better logging feat(jsonata): validation, caching, better logging Oct 8, 2024
@rarkins rarkins requested a review from viceice October 8, 2024 07:57
viceice
viceice previously approved these changes Oct 8, 2024
@rarkins rarkins added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit da4ee8b Oct 8, 2024
38 checks passed
@rarkins rarkins deleted the feat/jsonata-caching branch October 8, 2024 09:18
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 38.113.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

zemnmez-renovate-bot added a commit to zemn-me/monorepo that referenced this pull request Oct 8, 2024
github-merge-queue bot pushed a commit to zemn-me/monorepo that referenced this pull request Oct 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants