fix(onboarding): onboarding prs can have semantic prefixes causing repo to skip onboarded status. #29285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arded and become activated
viceice
reviewed
May 27, 2024
Co-authored-by: Michael Kriese <[email protected]>
…arded and become activated
|
fixed lint and tested, should be fine |
rarkins
approved these changes
May 28, 2024
|
🎉 This PR is included in version 37.381.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
added an extra check for pr source branch to not be onboarding PR ( configure/renovate by default)
Context
while having semantic prefix in my PR the PR title became
chore: Configure Renovatecausing the repository to go to Activated status immediately after merging the PR.the expected is for the repo to be
onboardedstatus and notactivated!Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: