recognizing dependencies in buildSrc project with gradle.kts #7953

Monax111 · 2020-07-21T12:05:56Z

Monax111
Jul 21, 2020

Which Renovate are you using?

Renovate Open Source CLI

Which platform are you using?

Bitbucket Server

Have you checked the logs? Don't forget to include them if relevant

fullLog.txt

What would you like to do?

I want update version spring in file buildSrc/build.gradle.kts
i find default regex for my template(gradle) '\.gradle(\.kts)?$'
i'ts look like it regex must find my file with twice match in it, but NO! i can't see any PR

my buildSrc/build.gradle.kts (trimmed)

plugins {
    id("org.springframework.boot") version "2.2.4.RELEASE" apply false
}

repositories {
    maven("https://registry.tcsbank.ru/repository/mvn-proxy-jcenter-release/")
}

kotlinDslPluginOptions {
    experimentalWarning.set(false)
}

dependencies {
    implementation("org.springframework.boot:spring-boot-gradle-plugin:2.2.4.RELEASE")
    
}

my config (trimmed)

"renovate-config": {
	"base-backend-kotlin": {
      "description": "Default base configuration for bpm kotlin backend applications",
      "extends": [
        ":ignoreUnstable",
        ":prImmediately",
        ":semanticCommits",
        ":semanticCommitTypeAll(renovatebot)",
        ":updateNotScheduled",
        ":automergeDisabled",
        ":ignoreModulesAndTests"
      ],
      "baseBranches": [
        "develop"
      ],
      "gradle": {
        "enable": true
      },
      "packageRules": [
        {
          "groupName": "jetbrains-kotlin",
          "packagePatterns": [
            "^org.jetbrains.kotlin"
          ]
        },
        {
          "groupName": "spring",
          "packagePatterns": [
            "^org.springframework:"
          ]
        },
        {
          "groupName": "spring-boot",
          "packagePatterns": [
            "^org.springframework.boot:"
          ]
        },
        {
          "groupName": "spring-cloud",
          "packagePatterns": [
            "^org.springframework.cloud:"
          ]
        },
       
      ]
    }
  }

viceice · 2020-07-21T12:13:54Z

viceice
Jul 21, 2020
Maintainer

Your log is truncated, we need the full log

0 replies

viceice · 2020-07-21T12:14:18Z

viceice
Jul 21, 2020
Maintainer

Please provide a public reproduction repo

0 replies

Monax111 · 2020-07-22T11:54:12Z

Monax111
Jul 22, 2020
Author

@viceice, sorry, didn't notice what log is truncated
new log - fullLog.txt

About public reproduction repo: we have private bitbacked and private registry.
I create repo , But we use custom preset (bpm-renovate:base-backend-kotlin) and i don't know how share it!. I have only source
config.txt

We start renovatebot with gitBush (file - start.sh)

is that enough or is it necessary to make a fully working project?

0 replies

Monax111 · 2020-07-22T12:03:14Z

Monax111
Jul 22, 2020
Author

in log i see my file:

DEBUG: Matched 15 file(s) for manager gradle: build.gradle.kts, buildSrc/build.gradle.kts, ...

but after i dont see what renovate try update version of plugin id("org.springframework.boot") version "2.2.4.RELEASE" and version dependency "implementation("org.springframework.boot:spring-boot-gradle-plugin:2.2.4.RELEASE")"

0 replies

rarkins · 2020-07-22T12:05:33Z

rarkins
Jul 22, 2020
Maintainer

So is the title of this issue wrong?

0 replies

Monax111 · 2020-07-22T12:08:37Z

Monax111
Jul 22, 2020
Author

@rarkins yes! But i dont know what is the problem to rename the title

0 replies

rarkins · 2020-07-22T12:21:03Z

rarkins
Jul 22, 2020
Maintainer

This is why a reproduction repository is important, otherwise we have little chance of guessing

0 replies

Monax111 · 2020-07-22T15:10:19Z

Monax111
Jul 22, 2020
Author

@rarkins i do it, but it's update only version Gradle(

change token https://github.com/Monax111/test/blob/develop/config.js
run in console file start.sh

now i see error

 "message": "Pushing to https://**redacted**@github.com': No such device or address\n",
         "stack": "Error: Pushing to https://**redacted**@github.com': No such device or address\n\n    at GitExecutorChain.onFatalException (/usr/src/app/node_modules/simple-git/src/lib/runners/git-executor-chain.ts:59:77)\n    at GitExecutorChain.<anonymous> (/usr/src/app/node_modules/simple-git/src/lib/runners/git-executor-chain.ts:51:21)\n    at Generator.throw (<anonymous>)\n    at rejected (/usr/src/app/node_modules/simple-git/src/lib/runners/git-executor-chain.js:6:65)\n    at runMicrotasks (<anonymous>)\n    at processTicksAndRejections (internal/process/task_queues.js:97:5)"

0 replies

rarkins · 2020-07-22T15:13:13Z

rarkins
Jul 22, 2020
Maintainer

Sorry, but I don't understand

0 replies

Monax111 · 2020-07-22T15:30:02Z

Monax111
Jul 22, 2020
Author

@rarkins sorry, I had to explain in more detail

Now i have test project. Project on Spring+Gradle(kts)
I try use renovateBot for this project, and expect 5 PR:

build.gradle.kts:
id("org.springframework.boot") version "2.2.8.RELEASE" -> "2.3.1.RELEASE"
id("io.spring.dependency-management") version "1.0.8.RELEASE" -> "1.0.9.RELEASE"
kotlin("jvm") version "1.3.60" ->"1.3.71"

buildSrc/build.gradle.kts:
id("org.springframework.boot") version "2.2.8.RELEASE"apply false -> "2.3.1.RELEASE"

gradle/wrapper/gradle-wrapper.properties
distributionUrl=https://services.gradle.org/distributions/gradle-6.4.1-bin.zip -> 6.5.1

I use self-host to start renovateBot(see file)
I have only one PR on gradle-wrapper. I would like to get 4 more PR after finish start.sh. In logs i see, whet renovate recognized old version, but can't push PR.
fullLog.txt

0 replies

rarkins · 2020-07-22T15:38:47Z

rarkins
Jul 22, 2020
Maintainer

Is that the same error that you get when you run on your private server?

0 replies

rarkins · 2020-07-22T15:39:38Z

rarkins
Jul 22, 2020
Maintainer

For example based on that error message, it's possible that the token you use does not have permissions to push

0 replies

Monax111 · 2020-07-22T16:15:12Z

Monax111
Jul 22, 2020
Author

Is that the same error that you get when you run on your private server?

No! on the private server i get no errors( And no PR(((

Yes, it's my fault (extra space after the token)!.

Now i have 2 PR!! Progress)))
I Expect PR on org.springframework.boot.gradle.plugin "2.2.8.RELEASE" -> "2.3.1.RELEASE" in file build.gradle.kts and buildSrc/build.gradle.kts. In log i see what renovate recognized it!

 packageFiles with updates (repository=Monax111/test)
       "config": {
         "gradle": [
           {
             "packageFile": "build.gradle.kts",
             "datasource": "maven",
             "deps": [
               {
                 "name": "org.springframework.boot.gradle.plugin",
                 "depGroup": "org.springframework.boot",
                 "depName": "org.springframework.boot:org.springframework.boot.gradle.plugin",
                 "currentValue": "2.2.8.RELEASE",
                 "registryUrls": [
                   "https://repo.maven.apache.org/maven2/",
                   "https://plugins.gradle.org/m2"
                 ],
                 "depIndex": 0,
                 "updates": [
                   {
                     "fromVersion": "2.2.8.RELEASE",
                     "toVersion": "2.3.1.RELEASE",
                     "newValue": "2.3.1.RELEASE",
                     "newMajor": 2,
                     "newMinor": 3,
                     "updateType": "minor",
                     "isSingleVersion": true
                   }
                 ],
                 "warnings": [],
                 "sourceUrl": "https://github.com/spring-projects/spring-boot",
                 "homepage": "https://spring.io/projects/spring-boot"
               }, ...

But RP does not exist.

Same with kotlin("jvm") version "1.3.60" ->"1.3.71" - No PR, but logs contains update

currentLog.txt

0 replies

rarkins · 2020-07-22T16:33:15Z

rarkins
Jul 22, 2020
Maintainer

Looking at the log, it collapses 25 updates into 4 branches:

DEBUG: Returning 4 branch(es) (repository=Monax111/test)

There is an unrelated error you can ignore as it's caused by a changelog file being > 1MB:

DEBUG: Unknown GitHub error (repository=Monax111/test)

Further down you can see this:

DEBUG: Creation of new PRs is blocked by existing PRs (repository=Monax111/test)
       "prs": 0

So please run again after the next hour starts, or add "prHourlyLimit": 0 to your renovate.json.

0 replies

Monax111 · 2020-07-23T10:33:17Z

Monax111
Jul 23, 2020
Author

Looking at the log, it collapses 25 updates into 4 branches:
Now i see 3 branch with 6 updates. updates = line?

So please run again after the next hour starts, or add "prHourlyLimit": 0 to your renovate.json.
Yes! i add this parametr and now i have 4 change) But default value already 0?
https://docs.renovatebot.com/configuration-options/#prhourlylimit
looks very strange?

today i try to experiment with plugin:

now i have PR on update Spring(it's cool)
But i haven't PR on second plugin
in fullLog.txt i can't find any about this plugin("com.gorylenko.gradle-git-properties")
I think problen in gradle task "renovate" ? i can't find documentation about this task.

0 replies

rarkins · 2020-07-23T10:41:23Z

rarkins
Jul 23, 2020
Maintainer

But default value already 0?

It is 2 in config:base, which you extend.

So the problem is that one dependency is never detected? Are any other dependencies detected in the same file?

0 replies

Monax111 · 2020-07-23T10:48:33Z

Monax111
Jul 23, 2020
Author

So the problem is that one dependency is never detected? Are any other dependencies detected in the same file?
Renovate recognized spring, and create PR, but don't recognized git-properties plugin

0 replies

Monax111 · 2020-07-23T10:55:31Z

Monax111
Jul 23, 2020
Author

I think the problem may be that the gradle task Renovate does not collect dependencies from the buildSrc project. I apply Spring to the main project, but git-properties does not. Git-properties just define in buildSrc project.

0 replies

rarkins · 2020-07-23T11:04:32Z

rarkins
Jul 23, 2020
Maintainer

config:base ignores test directories by default. Please merge this so we can try without it: Monax111/test#17

0 replies

Monax111 · 2020-07-23T11:13:40Z

Monax111
Jul 23, 2020
Author

@rarkins

Merged
cleared old PR and branch
Start Renovate
fullLog.txt
now i see 3 PR on Spring(PR are the same) and No Pr on git-properties plugin

0 replies

Monax111 · 2020-07-24T08:19:12Z

Monax111
Jul 24, 2020
Author

@rarkins i move this plugin to root build and it work) i see PR on git-property!
it's bug? Or this is the expected behavior?

0 replies

rarkins · 2020-07-24T08:22:08Z

rarkins
Jul 24, 2020
Maintainer

This seems like a bug to me. @ikesyo can you confirm?

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

recognizing dependencies in buildSrc project with gradle.kts #7953

{{title}}

Replies: 22 comments

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

recognizing dependencies in buildSrc project with gradle.kts #7953

Monax111 Jul 21, 2020

Which Renovate are you using?

Which platform are you using?

Have you checked the logs? Don't forget to include them if relevant

What would you like to do?

Replies: 22 comments

viceice Jul 21, 2020 Maintainer

viceice Jul 21, 2020 Maintainer

Monax111 Jul 22, 2020 Author

Monax111 Jul 22, 2020 Author

rarkins Jul 22, 2020 Maintainer

Monax111 Jul 22, 2020 Author

rarkins Jul 22, 2020 Maintainer

Monax111 Jul 22, 2020 Author

rarkins Jul 22, 2020 Maintainer

Monax111 Jul 22, 2020 Author

rarkins Jul 22, 2020 Maintainer

rarkins Jul 22, 2020 Maintainer

Monax111 Jul 22, 2020 Author

rarkins Jul 22, 2020 Maintainer

Monax111 Jul 23, 2020 Author

rarkins Jul 23, 2020 Maintainer

Monax111 Jul 23, 2020 Author

Monax111 Jul 23, 2020 Author

rarkins Jul 23, 2020 Maintainer

Monax111 Jul 23, 2020 Author

Monax111 Jul 24, 2020 Author

rarkins Jul 24, 2020 Maintainer

Monax111
Jul 21, 2020

viceice
Jul 21, 2020
Maintainer

viceice
Jul 21, 2020
Maintainer

Monax111
Jul 22, 2020
Author

Monax111
Jul 22, 2020
Author

rarkins
Jul 22, 2020
Maintainer

Monax111
Jul 22, 2020
Author

rarkins
Jul 22, 2020
Maintainer

Monax111
Jul 22, 2020
Author

rarkins
Jul 22, 2020
Maintainer

Monax111
Jul 22, 2020
Author

rarkins
Jul 22, 2020
Maintainer

rarkins
Jul 22, 2020
Maintainer

Monax111
Jul 22, 2020
Author

rarkins
Jul 22, 2020
Maintainer

Monax111
Jul 23, 2020
Author

rarkins
Jul 23, 2020
Maintainer

Monax111
Jul 23, 2020
Author

Monax111
Jul 23, 2020
Author

rarkins
Jul 23, 2020
Maintainer

Monax111
Jul 23, 2020
Author

Monax111
Jul 24, 2020
Author

rarkins
Jul 24, 2020
Maintainer