hostRules -> yarnrc.yml npmRegistries should have https prefix

[RGunning]

Tell us more.

At the moment, when constructing the yarnrc from the hostRules the https: prefix is stripped off the url

renovate/lib/modules/manager/npm/post-update/rules.ts

Lines 24 to 27 in a5d1b53

	is.string(uri) && validateUrl(uri)
	? uri.replace(regEx(/^https?:/), '')
	: // TODO: types (#22198)
	`//${uri}/`;

e.g.

npmRegistries:
  "//my-private-regsistry":
    npmAuthToken: xxxxxx

However, logging in with yarn config set --home npmRegistryServer "https://my-private-regsistry" && yarn config login would add a .yarnrc.yml

npmRegistries:
  "https://my-private-regsistry":
    npmAuthToken: xxxxxx

This leads to a different config on developers machines vs in renovate.

then in repository yarnrc files if you need to set npmAlwaysAuth

for it to work on a developer machine you need

npmRegistries:
  "https://my-private-regsistry":
    npmAlwaysAuth: true

but for renovate you need

npmRegistries:
  "//my-private-regsistry":
    npmAlwaysAuth: true

and yarn get's conflicts if you try adding both with and without the https: prefix.

As Yarn adds the https: prefix it would make sense to modify

renovate/lib/modules/manager/npm/post-update/rules.ts

Lines 24 to 27 in a5d1b53

	is.string(uri) && validateUrl(uri)
	? uri.replace(regEx(/^https?:/), '')
	: // TODO: types (#22198)
	`//${uri}/`;

so that the https: prefix is left there too.

[rarkins]

Do we know if all versions of Yarn using yarnrc.yml support https:// ?

[RGunning]

not sure, I've just been trying with [email protected]

Maybe one option would be to add a fuzzy matching of keys when merging the existingYarnrRcYml and additionalYarnRcYml.

so instead of merging

A yarnrc.yml

npmRegistries:
  "https://my-private-regsistry":
    npmAlwaysAuth: true

and B yarnrc.yml

npmRegistries:
  "//my-private-regsistry":
    npmAuthToken: xxxxxx

as

npmRegistries:
  "https://my-private-regsistry":
    npmAlwaysAuth: true
  "//my-private-regsistry":
    npmAuthToken: xxxxxx

we could detect that A already has a key matching so we get

npmRegistries:
  "https://my-private-regsistry":
    npmAlwaysAuth: true
    npmAuthToken: xxxxxx

This solve the conflicts documented here
https://docs.renovatebot.com/getting-started/private-packages/#yarn-2

const fuzzyMatchAdditionalYarnRcYml = {
  ...additionalYarnRcYml,
  npmRegistries: Object.entries(additionalYarnRcYml.npmRegistries || {})
    .map(([k, v]) => {
      const key = Object.keys(existingYarnrRcYml.npmRegistries || {}).find(
        (x) => x.endsWith(k),
      ) ?? k;
      return { [key]: v };
    })
    .reduce((acc, cur) => ({ ...acc, ...cur }), {}),
};

const updatedYarnYrcYml = deepmerge(
existingYarnrRcYml,
fuzzyMatchAdditionalYarnRcYml,
);

[rarkins]

PRs welcome!

[RGunning]

created a PR #26922