PostUpgradeTasks execution not logged

[vanpeter7]

Tell us more.

Hi,

we are using renovate version 29.32.5. When there are allowedPostUpgradeCommands set there is some logging about postUpgradeTasks execution like following
WARN: Post-upgrade task did not match any on allowed list (repository=…)
"dep": "…",
"cmd": "echo postUpgradeCommands executed",
"allowedPostUpgradeCommands": ["^git .*"]

If the allowedPostUpgradeCommands are empty there isn't any logging about disabled task execution. It took some time for me to find that allowedPostUpgradeCommands should be set in order to execute post upgrade commands.
Can you please add some logging for this scenario?

Thanks and regards,
Peter

[github-actions[bot]]

Hi there,

You're reporting a problem with an old version of Renovate. Please try the latest version and tell us if that fixes your problem.

Good luck,

The Renovate team

[pkubowicz]

There is no improvement in version 37.385.0. Not a single line from Renovate that it ignored your post-upgrade tasks. I checked renovate-log.ndjson that contains debug-level messages.

A warning should be printed when postUpgradeTasks key is present but allowedPostUpgradeCommands key is not defined
It's easy to check and saves a lot of time when you use post-upgrade tasks for the first time.

Ideally, a warning should be also printed when postUpgradeTasks are defined, but at least one of them is ignored because it does not match allowedPostUpgradeCommands. Writing regular expressions that match shell commands can be tricky, it's easy to fail to match, and an information about failed match from Renovate would again save lots of time.

To me, for every post-upgrade task, at least 1 line should be logged:

• either with the execution of the command
• or saying that the command was ignored

[pkubowicz]

Here is the project: https://github.com/pkubowicz/renovate-post-upgrade

[rarkins]

Please complete the reproduction so that actual upgrade PR is run - so far it's just at onboarding stage.

Also is this the actual way you are running? Usually postUpgradeTasks is in repo config, not global config.

[pkubowicz]

I updated readme with a link to logs where an actual upgrade PR is created.

Yes, I'm putting postUpgradeTasks to the global config (and it works, after tweaking allowedPostUpgradeCommands). For now I'm doing trial-and-error to fix Gradle lock files, and with global config I need to commit to 1 repo only, which is convenient. After I find a working solution, I will probably move postUpgradeTasks to repo config.

[rarkins]

#29538

[rarkins]

Example PR with that change: renovate-reproductions/26549#2

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues.

To get started, please read our guide on creating a minimal reproduction.

Good luck,

The Renovate team